List Keymap: Fix backspace behavior when selection is not collapsed #5810
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Overview
Fixes #4368
Implementation Approach
I figured that just checking if selection's
to
andfrom
doesn't match, default backspace behavior will result in expected behavior. So I added check to handleBackspace.ts.Testing Done
N/A
Verification Steps
/preview/Extensions/ListKeymap
.If you created list with one list item there will be no error in console. If you created list with multiple list items, the behavior will be as expected. Compare this with previous behavior either of tiptap's
develop
or live exampleChecklist
Related Issues
#4368