Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clear mark parse rules to bold & italic marks #5705

Merged
merged 1 commit into from
Oct 20, 2024

Conversation

mgreystone
Copy link
Contributor

Changes Overview

Resolves #5585

Adds parse rules to bold & italic that remove marks from their parent styles.

Implementation Approach

This is a port of prosemirror-schema-basic. When parsing a font-weight=400 or font-style=normal style, use the clearMark directive to clear the bold or italic marks respectively.

ProseMirror/prosemirror-schema-basic@6521792.

Testing Done

I tested my changes in the demo application. I asserted that HTML inserted into the editor are now parsed as expected, both from the clipboard & directly via commands.setContent

Verification Steps

Ensure that HTML that nest font-weight & font-style tags are styled as expected.

Input

<p style="font-weight: 700;">
  <span style="font-weight: 700;">I am Bold</span>
  <span style="font-weight: 400;">I am not Bold</span>
</p>

Expectation

doc(paragraph(bold("I am Bold "), "I am not Bold"))

Input

<p style="font-style: italic">
  <span style="font-style: italic">I am Italic</span>
  <span style="font-style: normal">I am not Italic</span>
</p>

Expectation

doc(paragraph(italic("I am Italic "), "I am not Italic"))

Additional Notes

Checklist

  • I have created a changeset for this PR if necessary.
  • My changes do not break the library.
  • I have added tests where applicable.
  • I have followed the project guidelines.
  • I have fixed any lint issues.

Related Issues

Copy link

changeset-bot bot commented Oct 8, 2024

🦋 Changeset detected

Latest commit: 28c9566

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 54 packages
Name Type
@tiptap/extension-italic Patch
@tiptap/extension-bold Patch
@tiptap/core Patch
@tiptap/extension-blockquote Patch
@tiptap/extension-bubble-menu Patch
@tiptap/extension-bullet-list Patch
@tiptap/extension-character-count Patch
@tiptap/extension-code-block-lowlight Patch
@tiptap/extension-code-block Patch
@tiptap/extension-code Patch
@tiptap/extension-collaboration-cursor Patch
@tiptap/extension-collaboration Patch
@tiptap/extension-color Patch
@tiptap/extension-document Patch
@tiptap/extension-dropcursor Patch
@tiptap/extension-floating-menu Patch
@tiptap/extension-focus Patch
@tiptap/extension-font-family Patch
@tiptap/extension-gapcursor Patch
@tiptap/extension-hard-break Patch
@tiptap/extension-heading Patch
@tiptap/extension-highlight Patch
@tiptap/extension-history Patch
@tiptap/extension-horizontal-rule Patch
@tiptap/extension-image Patch
@tiptap/extension-link Patch
@tiptap/extension-list-item Patch
@tiptap/extension-list-keymap Patch
@tiptap/extension-mention Patch
@tiptap/extension-ordered-list Patch
@tiptap/extension-paragraph Patch
@tiptap/extension-placeholder Patch
@tiptap/extension-strike Patch
@tiptap/extension-subscript Patch
@tiptap/extension-superscript Patch
@tiptap/extension-table-cell Patch
@tiptap/extension-table-header Patch
@tiptap/extension-table-row Patch
@tiptap/extension-table Patch
@tiptap/extension-task-item Patch
@tiptap/extension-task-list Patch
@tiptap/extension-text-align Patch
@tiptap/extension-text-style Patch
@tiptap/extension-text Patch
@tiptap/extension-typography Patch
@tiptap/extension-underline Patch
@tiptap/extension-youtube Patch
@tiptap/html Patch
@tiptap/pm Patch
@tiptap/react Patch
@tiptap/starter-kit Patch
@tiptap/suggestion Patch
@tiptap/vue-2 Patch
@tiptap/vue-3 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Oct 8, 2024

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit 28c9566
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/670541e4078ca20008a71c70
😎 Deploy Preview https://deploy-preview-5705--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@nperez0111 nperez0111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate the contribution!

@nperez0111 nperez0111 merged commit 6fae240 into ueberdosis:develop Oct 20, 2024
14 checks passed
@mgreystone mgreystone deleted the clear-bold-italic-marks branch October 22, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Parsing Nested Font Styles Does Not Clear Marks
2 participants