Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove podman-firewalld-reload.service when upstream fixes issue #92

Closed
bsherman opened this issue Oct 19, 2023 · 1 comment · Fixed by #116
Closed

remove podman-firewalld-reload.service when upstream fixes issue #92

bsherman opened this issue Oct 19, 2023 · 1 comment · Fixed by #116
Labels
upstream

Comments

@bsherman
Copy link
Collaborator

See #90 for context.
@bsherman bsherman mentioned this issue Oct 19, 2023
Closed
@bsherman
Copy link
Collaborator Author

bsherman commented Dec 7, 2023

Looks like the fix is in! https://blog.podman.io/2023/11/new-netavark-firewalld-reload-service/

The new service netavark-firewalld-reload.service does what my podman-firewalld-reload.service does and probably better.

Confirm it's present on our images, and use it instead of my hack.

bsherman added a commit that referenced this issue Jan 17, 2024
@bsherman
feat: use upstream netavark-firewalld-reload instead of home grown tool
007aac1 
I'd previously created podman-firewalld-reload.service, but now Netavark
has provided their own netavark-firewalld-reload.service. Always prefer
the upstream tool, so removing the custom tool and updating docs.

Closes: #92
@bsherman bsherman mentioned this issue Jan 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
upstream
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: use upstream netavark-firewalld-reload instead of home grown tool ublue-os/ucore
1 participant
@bsherman