Skip to content

Commit

Permalink
feat: use upstream netavark-firewalld-reload instead of home grown tool
Browse files Browse the repository at this point in the history
I'd previously created podman-firewalld-reload.service, but now Netavark
has provided their own netavark-firewalld-reload.service. Always prefer
the upstream tool, so removing the custom tool and updating docs.

Closes: #92
  • Loading branch information
bsherman committed Jan 17, 2024
1 parent 1a04949 commit 007aac1
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 18 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ NOTE: CoreOS [cautions against](https://docs.fedoraproject.org/en-US/fedora-core

Podman and firewalld [can sometimes conflict](https://github.com/ublue-os/ucore/issues/90) such that a `firewall-cmd --reload` removes firewall rules generated by podman.

A service is included to mitigate this by monitoring for firewall reload events on dbus and then reloading podman networks. If needed, enable like so: `systemctl enable --now podman-firewalld-reload.service`
As of [netavark v1.9.0](https://blog.podman.io/2023/11/new-netavark-firewalld-reload-service/) a service is provided to handle re-adding netavark (Podman) firewall rules after a firewalld reload occurs. If needed, enable like so: `systemctl enable netavark-firewalld-reload.service`


### Distrobox
Expand Down
1 change: 0 additions & 1 deletion ucore/packages.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
"cockpit-selinux",
"cockpit-storaged",
"cockpit-system",
"dbus-tools",
"distrobox",
"duperemove",
"firewalld",
Expand Down
16 changes: 0 additions & 16 deletions ucore/usr/lib/systemd/system/podman-firewalld-reload.service

This file was deleted.

0 comments on commit 007aac1

Please sign in to comment.