-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Split justfiles into multiple numbered files to fix issue with default command on other releases. #118
Conversation
…efault command on other releases.
cc @ublue-os/approver for feedback. I think we need to account for recreating the existing user's |
Alternative option, do we have the ability to define what's in |
For my image, I have aliased The
This gets around the requirement for justfiles to be installed at a user level. RE bsherman's comment about Nvidia, you could simply copy over the justfile for all images, and add the include only during Nvidia builds. Just an idea... But there could be a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm requesting these changes, but let me know if I'm off base.
I like @p5's idea of using an alias, except that might require a little more effort to be supported across different shells. is there appetite for having a fairly simple cli that wraps just and sets up paths on its own? In the meantime, what about having a master justfile in
You still have to deal with the user being able to edit ~/.justfile, but its a start 😉 |
Latest commit does the master justfile as /usr/share/ublue-os/justfile, now we just need the .justfile editor as mentioned |
…in /usr/share/ublue-os/just/*.just
94151aa
to
fe9dee7
Compare
…o new /usr/share/ublue-os/justfile fixme: Modify existing .justfiles to have this same change in a non-destructive way.
…ve user-added lines. chore: Minor spec cleanup
1d6ced5
to
131e0de
Compare
feat: Add installer for obs-studio-portable
This now depends on this landing first: |
… module, print a helpful message if it's not found.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, can confirm things are working as intended!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Good improvements here!
Depends on the following PR landing: ublue-os/config#118
Cleaner thanks to commands now being categorized, and additionally fixes an issue where just files are loaded alphabetically and the default command can change as new files are added.
Brings in comments and listing improvements made at Bazzite.