Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use --nvidia when creating distrobox containers + Switch to new justfile system #47

Merged
merged 1 commit into from
Sep 24, 2023

Conversation

KyleGospo
Copy link
Contributor

Depends on the following PR landing:
ublue-os/config#118

@KyleGospo KyleGospo changed the title fix: Use --nvidia when creating distrobox containers + Justfile update fix: Use --nvidia when creating distrobox containers + Switch to new justfile system Sep 22, 2023
feat: Switch to new numbered justfile system
@xynydev
Copy link
Member

xynydev commented Sep 22, 2023

Why the removal of set allow-duplicate-recipes, doesn't that break things? Also, a corresponding PR for startingpoint needs to be done before merging this: (https://github.com/ublue-os/startingpoint/blob/template/config/files/usr/share/ublue-os/just/custom.just). I can also PR startingpoint, once I know what the correct course of action is. Should custom.just also be named with a number prefix? And with this new system, does 100-bling.just have to be included in it or is it included automatically?

Edit: Answers:

  • rename custom.just to 60-custom.just
  • change include to include 100-bling.just (in startingpoint after this PR is merged)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants