Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pip bootstrapping on Python 2.7 #475

Merged
merged 1 commit into from
Jan 26, 2021
Merged

Fix pip bootstrapping on Python 2.7 #475

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/install_python_deps.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ set -e
NEUROPOD_PYTHON_BINARY="python${NEUROPOD_PYTHON_VERSION}"

# Install pip
wget https://bootstrap.pypa.io/get-pip.py -O /tmp/get-pip.py
wget https://bootstrap.pypa.io/2.7/get-pip.py -O /tmp/get-pip.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I see it is used at build/ci/install_lint_deps.sh too.
  2. Does it make sense to cache it? like:
tools/lint.sh-    if [ ! -f "/tmp/buildifier" ]; then
tools/lint.sh:        wget https://github.com/bazelbuild/buildtools/releases/download/2.2.1/buildifier -O /tmp/buildifier
tools/lint.sh-        chmod +x /tmp/buildifier
tools/lint.sh-    fi

or it is not used often?

Copy link
Collaborator Author

@VivekPanyam VivekPanyam Jan 26, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not used often. The reason I built the caching in the lint script above (and some other places) is because those can be used a lot

${NEUROPOD_PYTHON_BINARY} /tmp/get-pip.py

# Setup a virtualenv
Expand Down