Fix pip bootstrapping on Python 2.7 #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -5,7 +5,7 @@ set -e | |||
| NEUROPOD_PYTHON_BINARY="python${NEUROPOD_PYTHON_VERSION}" | |||
|
|
|||
| # Install pip | |||
| wget https://bootstrap.pypa.io/get-pip.py -O /tmp/get-pip.py | |||
| wget https://bootstrap.pypa.io/2.7/get-pip.py -O /tmp/get-pip.py | |||
There was a problem hiding this comment.
- I see it is used at build/ci/install_lint_deps.sh too.
- Does it make sense to cache it? like:
tools/lint.sh- if [ ! -f "/tmp/buildifier" ]; then
tools/lint.sh: wget https://github.com/bazelbuild/buildtools/releases/download/2.2.1/buildifier -O /tmp/buildifier
tools/lint.sh- chmod +x /tmp/buildifier
tools/lint.sh- fi
or it is not used often?
There was a problem hiding this comment.
Not used often. The reason I built the caching in the lint script above (and some other places) is because those can be used a lot
vkuzmin-uber
approved these changes
Jan 26, 2021
Codecov Report
@@ Coverage Diff @@
## master #475 +/- ##
=======================================
Coverage 88.23% 88.23%
=======================================
Files 106 106
Lines 6852 6852
=======================================
Hits 6046 6046
Misses 806 806 Continue to review full report at Codecov.
|
vkuzmin-uber
pushed a commit
that referenced
this pull request
Mar 15, 2021
### Summary: The latest version of pip drops support for Python 2.7 (pypa/pip#6148). This PR modifies `install_python_deps.sh` to install a Python 2.7 compatible version of pip. We should also explore dropping Python 2.7 support in the future as it's been over a year since its EOL. ### Test Plan: CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The latest version of pip drops support for Python 2.7 (pypa/pip#6148).
This PR modifies
install_python_deps.shto install a Python 2.7 compatible version of pip.We should also explore dropping Python 2.7 support in the future as it's been over a year since its EOL.
Test Plan:
CI