Fixed exception instantiations in BaseControllerProvider #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d authorize() methods.
plessbd
approved these changes
Apr 5, 2017
6 tasks
ryanrath
added a commit
to ryanrath/xdmod
that referenced
this pull request
Apr 14, 2017
- Updated the authenticate and authorize functions to use framework exceptions and not the homegrown ones. This was also done in ubccr#87
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Framework exceptions were being instantiated incorrectly (symfony).
Description
Some home-grown exceptions were also being thrown. These were replaced with Symfony framework exceptions.
Motivation and Context
Fixes bug; allows rest stack to throw exceptions.
Tests performed
Thoroughly exercised as part of ubccr/xdmod-supremm#28 integration tests; working on unit test now.
Types of changes
Checklist:
Caveats
Pull requests that depend on this fix are: