Convert old rest stack: base xdmod #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 22, 2017
jsperhac
force-pushed
the
convert-old-rest-stack
branch
from
f91feab
to
d4a90b7
Compare
6 tasks
jsperhac
force-pushed
the
convert-old-rest-stack
branch
2 times, most recently
from
6d43453
to
7641c7d
Compare
plessbd
reviewed
Apr 10, 2017
| @@ -179,21 +174,14 @@ public static function getInstance() | |||
| $app->mount($unversionedPathMountPoint, $controller); | |||
| } | |||
|
|
|||
| // SETUP: an error handler that will let us fall back to the old rest | |||
| // stack / controllers. | |||
| // SETUP: error handler | |||
| $app->error(function (\Exception $e, $code) use ($app) { | |||
There was a problem hiding this comment.
do we even need this anymore? Since we are not actually trying to fallback, what happens if this is just removed?
There was a problem hiding this comment.
I see lots of test errors on removal, so let's keep that code...
Remove legacy router code for old rest endpoints; remove extrest directory and remove old functions from libraries/rest code.
jsperhac
force-pushed
the
convert-old-rest-stack
branch
from
6e050b6
to
c2c9135
Compare
plessbd
approved these changes
Apr 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a step along the way toward killing off the old REST stack.
Remove entirely-unused source code from the old classes/REST rest stack. Remove the old documentation, html/rest_catalog/, that described these unused sources. This is a tidier implementation of my old pull request #422 from the xdmod-private ccr repo.
Refer to pull requests against xdmod-appkernel (ubccr/xdmod-appkernels#12) and xdmod-supremm (ubccr/xdmod-supremm#28) repositories that take this pull request further and convert the last remaining old REST stack remnants to use the NewRest controllers. Following the implementation of those pull requests we can remove the old REST stack entirely.
Description
Deleted 28 unused files and a number of directories:
Motivation and Context
The motivation behind this work is to:
Tests performed
Front-end was tested by hand in grotesque detail by submitter and by Bob, in November 2016, as part of old and rescinded pull request #422.
Internal dashboard was tested by hand using chrome debugger to observe which rest endpoints are in use for the dashboard functionality. Integration tests were introduced and make use of the integration test harness, for the supremm and appkernel portions.
Types of changes
Checklist:
Caveats:
More things I'd like to do related to the rest stacks:
To Do:
Remaining to do in this exercise: see pull requests named "convert-old-rest-stack" for appkernel and supremm modules.