Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance of OpenStackCloudEventAssetRootVolumeIngestor and GenericCloudEventAssetRootVolumeIngestor actions #1303

Merged
merged 7 commits into from
May 5, 2020
Merged

Improve performance of OpenStackCloudEventAssetRootVolumeIngestor and GenericCloudEventAssetRootVolumeIngestor actions #1303

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e4adb95
adding index to provider_identifier column on asset table to improve …
eiffel777 May 1, 2020
7348ee8
updated generic action for adding root volume to event asset table
eiffel777 May 4, 2020
f002e59
Merge branch 'xdmod9.0' into cloud-add-index-provider-account-asset
plessbd May 4, 2020
12517bf
adding resource_id to idx_provier_identifier key on asset table"
eiffel777 May 4, 2020
7ede530
Merge branch 'cloud-add-index-provider-account-asset' of https://gith…
eiffel777 May 4, 2020
cb14f4a
:Merge branch 'xdmod9.0' of https://github.com/ubccr/xdmod into cloud…
eiffel777 May 4, 2020
10a45e3
Merge branch 'xdmod9.0' into cloud-add-index-provider-account-asset
eiffel777 May 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion configuration/etl/etl_action_defs.d/cloud_generic/event_asset_root_volume.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,16 @@
},

"joins": [
{
"name": "generic_cloud_staging_event",
"schema": "${SOURCE_SCHEMA}",
"alias": "staging"
},
{
"name": "event",
"schema": "${SOURCE_SCHEMA}",
"alias": "ev"
"alias": "ev",
"on": "ev.resource_id = staging.resource_id AND ev.instance_id = staging.instance_id AND ev.event_time_ts = staging.event_time_ts AND ev.event_type_id = staging.event_type_id"
},
{
"name": "instance",
Expand Down
8 changes: 7 additions & 1 deletion configuration/etl/etl_action_defs.d/cloud_openstack/event_asset_root_volume.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,16 @@
},

"joins": [
{
"name": "openstack_staging_event",
"schema": "${SOURCE_SCHEMA}",
"alias": "staging"
},
{
"name": "event",
"schema": "${SOURCE_SCHEMA}",
"alias": "ev"
"alias": "ev",
"on": "ev.resource_id = staging.resource_id AND ev.instance_id = staging.instance_id AND ev.event_time_ts = staging.event_time_ts AND ev.event_type_id = staging.event_type_id"
},
{
"name": "instance",
Expand Down
8 changes: 8 additions & 0 deletions configuration/etl/etl_tables.d/cloud_common/asset.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,14 @@
"asset_id"
],
"is_unique": true
},
{
"name": "idx_provider_identifier",
"columns": [
"resource_id",
"provider_identifier"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't resource_id also be part of this index?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since presumably this is here to improve the performance of the following join?

a.resource_id = ev.resource_id AND a.provider_identifier = CONCAT('root-vol-', i.provider_identifier)"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpwhite4 It's been added

],
"is_unique": false
}
]
}
Expand Down