Improve performance of OpenStackCloudEventAssetRootVolumeIngestor and GenericCloudEventAssetRootVolumeIngestor actions #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpwhite4
reviewed
May 4, 2020
| { | ||
| "name": "idx_provider_identifier", | ||
| "columns": [ | ||
| "provider_identifier" |
There was a problem hiding this comment.
Shouldn't resource_id also be part of this index?
There was a problem hiding this comment.
Since presumably this is here to improve the performance of the following join?
a.resource_id = ev.resource_id AND a.provider_identifier = CONCAT('root-vol-', i.provider_identifier)"
There was a problem hiding this comment.
@jpwhite4 It's been added
…ub.com/eiffel777/xdmod into cloud-add-index-provider-account-asset
…-add-index-provider-account-asset
jpwhite4
approved these changes
May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The action xdmod.OpenStackCloudEventAssetRootVolumeIngestor is taking over two minutes to complete when ingesting data from the IU Jetstream system. Looking into it more there are two main performance issues, the first is that it selects all rows from the event table and the second is a join on a column that was not indexed. Adding an index to that column and making changes to the sql query so it does not select all rows from the event table result in a action now taking between 1 and 2 seconds when tested on xdmod-dev.
Tests performed
Tested on xdmod-dev.
Types of changes
Checklist: