Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed plugin prefixes from converter and merger paths #1203

Merged
merged 10 commits into from
Oct 17, 2021

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Flattens the converter and mergers directories to not rely on plugin-specific folders.

@JoshuaKGoldberg JoshuaKGoldberg changed the title Removed plugin prefixes from conveter and merger paths Removed plugin prefixes from converter and merger paths Aug 30, 2021
@JoshuaKGoldberg
Copy link
Member Author

@rafaelss95 - I'll leave this for a day in case you have opinions 🙂

@rafaelss95
Copy link
Contributor

rafaelss95 commented Aug 30, 2021

Hmmm, I see what you mentioned in #1197 (comment)... in this case wouldn't it be better then to use the original rule name as the file name + the converter function to keep them grouped, making it easier not only to search but also to read this huge amount of files together? I mean:

avoid-dispatching-multiple-actions-sequentially / convertAvoidDispatchingMultipleActionsSequentially -> ngrx-avoid-dispatching-multiple-actions-sequentially / convertNgrxAvoidDispatchingMultipleActionsSequentially
ban-operators / convertBanOperators -> rxjs-ban-operators / convertRxjsBanOperators

About the others which doesn't have a prefix (codelyzer, sonar, etc.), I think we can leave it as is.

@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for author The PR author should address requested changes label Sep 3, 2021
@JoshuaKGoldberg JoshuaKGoldberg removed the status: waiting for author The PR author should address requested changes label Oct 16, 2021
@JoshuaKGoldberg JoshuaKGoldberg merged commit ebc5278 into main Oct 17, 2021
@JoshuaKGoldberg JoshuaKGoldberg deleted the unified-converter-merger-paths branch October 17, 2021 22:50
@JoshuaKGoldberg
Copy link
Member Author

All right, sorry that took so long @rafaelss95! I believe I got everything under the original name. Please let me know if I missed any / got any wrong!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup: standardize ruleConverters/* paths internally
2 participants