Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: standardize ruleConverters/* paths internally #1197

Closed
JoshuaKGoldberg opened this issue Aug 29, 2021 · 2 comments · Fixed by #1203
Closed

Cleanup: standardize ruleConverters/* paths internally #1197

JoshuaKGoldberg opened this issue Aug 29, 2021 · 2 comments · Fixed by #1203
Assignees
Labels
status: accepting prs Please, send in a PR to resolve this! ✨ type: cleanup Code smells, incorrect tests, build systems, or other internal shenanigans

Comments

@JoshuaKGoldberg
Copy link
Member

Overview

Following up on https://github.com/typescript-eslint/tslint-to-eslint-config/pull/1194/files#r698063081, there's not a standard for how the sub-folders corresponding to third party plugins are named.

Actual Behavior

One folder is codelyzer (the old name), another eslint-plugin-react...

Expected Behavior

I'd expect these to generally be named after the old (TSLint) names...?

@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send in a PR to resolve this! ✨ type: cleanup Code smells, incorrect tests, build systems, or other internal shenanigans labels Aug 29, 2021
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Aug 30, 2021
@JoshuaKGoldberg
Copy link
Member Author

Actually, I just realized having plugin-specific folder names isn't going to work. Some rules are duplicated across plugins! no-constant-condition, for example, exists in both tslint-microsoft-contrib and tslint-eslint-rules.

I'll send a PR to remove the plugin names so everything is purely alphabetical by linter rule name.

@JoshuaKGoldberg
Copy link
Member Author

FYI @rafaelss95 - Apologies for the change of heart so soon after mentioning this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepting prs Please, send in a PR to resolve this! ✨ type: cleanup Code smells, incorrect tests, build systems, or other internal shenanigans
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant