Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: converters for ngrx rules #1194

Merged
merged 6 commits into from
Aug 30, 2021

Conversation

rafaelss95
Copy link
Contributor

PR Checklist

Overview

This PR adds converters for ngrx-* rules according to the migration guide.
The only missing rule is ngrx-no-duplicate-action-types, which was not migrated.

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, thanks! Just the one correction for (no)-effect-decorator-and-creator.

For ngrx-no-duplicate-action-types, the right move would be to make a converter that has no output rules. That way tslint-to-eslint-config won't log a complaint about not knowing an equivalent output rule.

@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for author The PR author should address requested changes label Aug 29, 2021
@rafaelss95
Copy link
Contributor Author

For ngrx-no-duplicate-action-types, the right move would be to make a converter that has no output rules. That way tslint-to-eslint-config won't log a complaint about not knowing an equivalent output rule.

Oh, thanks for clarifying this. In that case, I'll submit new PRs for the missing converters for codelyzer and tslint-rxjs-rules too.

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, thanks (again) @rafaelss95!

@JoshuaKGoldberg
Copy link
Member

I'll wait a bit in case you're still working on this (e.g. the folder renames), then merge before I go to bed tonight. Whatever you don't get in this PR I'd be happy to review as a fast follow.

@rafaelss95
Copy link
Contributor Author

Done, I've renamed the folder to ngrx-tslint-rules.

@JoshuaKGoldberg
Copy link
Member

Well, super - I'll go ahead and merge now!

@JoshuaKGoldberg JoshuaKGoldberg merged commit aba8350 into typescript-eslint:main Aug 30, 2021
@rafaelss95 rafaelss95 deleted the feat/ngrx branch August 30, 2021 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting for author The PR author should address requested changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing ngrx rule converters
2 participants