-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: converters for ngrx
rules
#1194
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me, thanks! Just the one correction for (no)-effect-decorator-and-creator
.
For ngrx-no-duplicate-action-types
, the right move would be to make a converter that has no output rules. That way tslint-to-eslint-config won't log a complaint about not knowing an equivalent output rule.
...nverters/lintConfigs/rules/ruleConverters/eslint-plugin-ngrx/effect-creator-and-decorator.ts
Outdated
Show resolved
Hide resolved
Oh, thanks for clarifying this. In that case, I'll submit new PRs for the missing converters for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super, thanks (again) @rafaelss95!
I'll wait a bit in case you're still working on this (e.g. the folder renames), then merge before I go to bed tonight. Whatever you don't get in this PR I'd be happy to review as a fast follow. |
Done, I've renamed the folder to |
Well, super - I'll go ahead and merge now! |
PR Checklist
status: accepting prs
Overview
This PR adds converters for
ngrx-*
rules according to the migration guide.The only missing rule is
ngrx-no-duplicate-action-types
, which was not migrated.