Skip to content

Handle EPOLLHUP in EpollSystem #4422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 24, 2025
Merged

Handle EPOLLHUP in EpollSystem #4422

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0bd3e5a
added epollhup
rahulrangers Jun 9, 2025
33cf7e0
added testcase
rahulrangers Jun 10, 2025
8907bc2
added helpers
rahulrangers Jun 12, 2025
dd192a6
name change
rahulrangers Jun 12, 2025
cfd5d2d
added gate
rahulrangers Jun 13, 2025
670f768
added gate
rahulrangers Jun 13, 2025
a67b776
added background
rahulrangers Jun 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion core/native/src/main/scala/cats/effect/unsafe/EpollSystem.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ object EpollSystem extends PollingSystem {
private[this] var writeCallback: Either[Throwable, Int] => Unit = null

def notify(events: Int): Unit = {
if ((events & EPOLLIN) != 0) {
if ((events & EPOLLIN) != 0 || (events & EPOLLHUP) != 0) {
val counter = readReadyCounter + 1
readReadyCounter = counter
val cb = readCallback
Expand Down Expand Up @@ -269,6 +269,7 @@ object EpollSystem extends PollingSystem {
final val EPOLLOUT = 0x004
final val EPOLLONESHOT = 1 << 30
final val EPOLLET = 1 << 31
final val EPOLLHUP = 1 << 4

type epoll_event
type epoll_data_t = Ptr[Byte]
Expand Down
12 changes: 12 additions & 0 deletions tests/native/src/test/scala/cats/effect/FileDescriptorPollerSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,18 @@ class FileDescriptorPollerSpec extends BaseSpec {
pipe.read(new Array[Byte](1), 0, 1).as(false).timeoutTo(1.second, IO.pure(true))
}
}

"handle EPOLLHUP events" in real {
mkPipe.use { pipe =>
for {
buf <- IO(new Array[Byte](4))
_ <- pipe.write(Array[Byte](1, 2, 3), 0, 3)
_ <- pipe.read(buf, 0, 3)
_ <- IO(unistd.close(pipe.writeFd))
_ <- pipe.read(buf, 3, 1)
} yield buf.toList must be_==(List[Byte](1, 2, 3, 0))
}
}
}

}
Loading