Skip to content

Handle EPOLLHUP in EpollSystem #4422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 24, 2025
Merged

Handle EPOLLHUP in EpollSystem #4422

merged 7 commits into from
Jun 24, 2025

Conversation

@rahulrangers
Copy link
Contributor

No description provided.

@rahulrangers
Copy link
Contributor Author

@armanbilge can you please Review this PR

@armanbilge armanbilge self-requested a review June 9, 2025 21:54
armanbilge
armanbilge reviewed Jun 9, 2025
View reviewed changes
Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Unfortunately the test you added is failing currently:

[error]   ! handle EPOLLHUP events
[error]    java.io.IOException: Bad file descriptor (null:0)
[error] apply @ org.specs2.specification.core.Execution$.withEnvAsync$$anonfun$1(Unknown Source)

@rahulrangers rahulrangers requested a review from armanbilge June 10, 2025 08:17
@rahulrangers
Copy link
Contributor Author

rahulrangers commented Jun 10, 2025 •
edited
Loading

@armanbilge I was getting the Bad file descriptor error because i was registering the writeFd with poller and closing it. So I have made mkReadOnlyPipe which is similar to mkpipe but i am only registering readFd with poller in it.

armanbilge
armanbilge reviewed Jun 11, 2025
View reviewed changes
Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated test looks good! Just a few suggestions to tidy up the implementation.

@rahulrangers rahulrangers requested a review from armanbilge June 12, 2025 02:49
@rahulrangers rahulrangers mentioned this pull request Jun 13, 2025
Open
armanbilge
armanbilge reviewed Jun 19, 2025
View reviewed changes
@rahulrangers rahulrangers requested a review from armanbilge June 19, 2025 20:03
@armanbilge armanbilge changed the title added epollhup in the epollsystem Handle EPOLLHUP in EpollSystem Jun 24, 2025
@armanbilge armanbilge merged commit 5a050ca into typelevel:series/3.6.x Jun 24, 2025
34 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@armanbilge armanbilge armanbilge approved these changes

Assignees

No one assigned

Labels

🪲 bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rahulrangers @armanbilge