Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type django.utils.* against Django 4.2 #1575
Type django.utils.* against Django 4.2 #1575
Changes from 19 commits
24bb669
f5acd45
73da5c6
23bcdaf
bfe0099
8d68967
9c4bf46
07d7e67
bcf113f
ed99ece
bc46a13
e140234
6ad9c4c
3cba615
1f3ae9d
79a4055
c0e9eed
9f32e95
e21ceca
7df6e5e
254edbf
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was just added in #1425, I don't think we should be removing it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Renamed it to
_AsyncGetResponseCallable
with regard to @sobolevn recommendation, and moved it indeprecation.pyi
, where I added a usage.I must say I don't have the full context for #1425 and #1269, so I'd be happy to rollback the changes and leave it for later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is my mistake: adding public protocols is not a good idea: because they do not exist at runtime. We must not promote importing them.
As far as I understand, this protocol is only used in our
django.utils
package.So, it should be protected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning this up, I had already forgotten.