Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type django.utils.* against Django 4.2 #1575

Merged
merged 21 commits into from
Jun 26, 2023
+178 −249
Merged

Type django.utils.* against Django 4.2 #1575

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
24bb669
Type all utils.* against Django 4.2
GabDug Jun 23, 2023
f5acd45
fix: cached_property.name could be None
GabDug Jun 24, 2023
73da5c6
fix: SessionMiddleware was not typed properly
GabDug Jun 24, 2023
23bcdaf
fix: conditional_escape should return SafeString, closes #1474
GabDug Jun 24, 2023
bfe0099
Merge branch 'master' into type-utils
sobolevn Jun 24, 2023
8d68967
chore: remove utils from allowlist
GabDug Jun 24, 2023
9c4bf46
chore: remove unrelated unused ignores from allowlist for CI
GabDug Jun 24, 2023
07d7e67
chore: mark Protocols as type_check_only
GabDug Jun 24, 2023
bcf113f
Merge branch 'master' into type-utils
GabDug Jun 26, 2023
ed99ece
Update scripts/stubtest/allowlist.txt
GabDug Jun 26, 2023
bc46a13
Update django-stubs/utils/deprecation.pyi
GabDug Jun 26, 2023
e140234
Merge branch 'type-utils' of github.com:GabDug/django-stubs into type…
GabDug Jun 26, 2023
6ad9c4c
fix: MultieValueDict should return Self
GabDug Jun 26, 2023
3cba615
fixes from MR review
GabDug Jun 26, 2023
1f3ae9d
chore: close #1269
GabDug Jun 26, 2023
79a4055
chore: remove legacy Self import from _typeshed
GabDug Jun 26, 2023
c0e9eed
chore: move async with its sync counterpart
GabDug Jun 26, 2023
9f32e95
chore: remove Trans from typings
GabDug Jun 26, 2023
e21ceca
chore: fix tests
GabDug Jun 26, 2023
7df6e5e
Apply suggestions from code review
GabDug Jun 26, 2023
254edbf
chore: use decorator syntax for cached_property
GabDug Jun 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update django-stubs/utils/deprecation.pyi 
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@GabDug @sobolevn
GabDug and sobolevn authored Jun 26, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
commit bc46a1313677e98124bd3170ea8ee8c0c55cf012
2 changes: 1 addition & 1 deletion django-stubs/utils/deprecation.pyi
View file
Original file line number Diff line number Diff line change
@@ -31,7 +31,7 @@ class DeprecationInstanceCheck(type):
def __instancecheck__(self, instance: Any) -> bool: ...

@type_check_only
class GetResponseCallable(Protocol):
class _GetResponseCallable(Protocol):
def __call__(self, __request: HttpRequest) -> HttpResponseBase: ...

class MiddlewareMixin: