Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use supported version in typecheck_tests command in Contributing guide #1251

Merged
merged 1 commit into from
Jan 27, 2023
Merged

fix: Use supported version in typecheck_tests command in Contributing guide #1251

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ We also test the stubs against Django's own test suite. This is done in CI but y
To execute the script run:

```bash
python ./scripts/typecheck_tests.py --django_version 3.1
python ./scripts/typecheck_tests.py --django_version 3.2
```


Expand All @@ -90,13 +90,13 @@ The stubs are based on auto-generated code created by Mypy's stubgen tool (see:
To make life easier we have a helper script that auto generates these stubs. To use it you can run:

```bash
python ./scripts/stubgen-django.py --django_version 3.1
python ./scripts/stubgen-django.py --django_version 3.2
```

You can also pass an optional commit hash as a second kwarg to checkout a specific commit, e.g.

```bash
python ./scripts/stubgen-django.py --django_version 3.1 --commit_sha <commit_sha>
python ./scripts/stubgen-django.py --django_version 3.2 --commit_sha <commit_sha>
```

The output for this is a gitignored folder called "stubgen" in the repo's root.
Expand Down