fix: Use supported version in typecheck_tests command in Contributing guide #1251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… guide The `typecheck_tests.py` script only supports the Django versions included in its `DJANGO_COMMIT_REFS` map. Version `3.1` is no longer present, so the command from the Contributing guide failed. For consistency, the Django version used for the `stubgen-django.py` commands has been also updated.
intgr
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
typecheck_tests.pyscript only supports the Django versions included in itsDJANGO_COMMIT_REFSmap. Version3.1is no longer present, so the command from the Contributing guide failed.For consistency, the Django version used for the
stubgen-django.pycommands has been also updated.