-
-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Next release planning (4.2.0) #1450
Comments
A related question is, do we adopt a similar version scheme for djangorestframework-stubs? Following djangorestframework upstream it would become 3.14.0. I assume the answer is yes, but it hasn't really been explicitly mentioned. |
I am not using |
FWIW, I think the new version scheme is what it should be and what is used in most of the rest of the community. |
|
django-stubs and django-stubs-ext 4.2.0 have been released! |
Due to a packaging issue, the new It's not a big deal though, I will continue wrapping up this release, and defer |
I have completed editing the release notes: https://github.com/typeddjango/django-stubs/releases/tag/4.2.0 |
Congrats, @intgr! Great work! 🎉 |
Just to expand on this point:
One of the reasons for this is that we don't need two separate |
Thank you once again @intgr. I'm going to roll this across my projects and will report any issues. |
Upgraded my 14 open source projects using django-stubs, no issues, one |
Stumbled on this trying to figure out why the example of TypedModelMeta wasn't working. I just installed django-stubs using pip (from pypi), and the db subpackage isn't there. Looks like you guys caught the packaging error, but might not have uploaded to pypi? |
@jp-larose check the comment above from @intgr @intgr: can you do a 4.2.1 release to include this? |
Oh... Ha! I missed the tail end of the comment where he said it would be deferred. |
Yep, sorry! I was planning to do the next release quicker, but have been postponing it. I'll try to get the release out in the next few days. |
Unpinning this issue, opened the next one: |
The next django-stubs release is way overdue. Since our last release, mypy 1.2.0 and Django 4.2 have been released.
compatible-mypy
version is already upgraded (#1429), and we already have some improvements for Django 4.2 support -- although it's far from complete.This also brings a scope increase todjango-stubs-ext
, it now offers a typehinted base class forModel
Meta
(#1375).New version numbering scheme
As discussed previously in #1095 (comment) and few other places, we want to adopt a new version numbering scheme, similar to typeshed
types-*
packages, where first two digits indicate latest Django version, and the third digit version is just a sequential counter of django-stubs releases. So first release after Django 4.2 will be django-stubs 4.2.0, next 4.2.1 etc.The downsides of this are:
django-stubs-ext
changes could have adverse effects on production code.If someone has arguments against this version scheme change, now is the last opportunity to voice them.
This new scheme would apply to both
django-stubs
anddjango-stubs-ext
(refs #1409). To avoid confusion, we should keep these version numbers in sync in the future (either we always release both, or if django-stubs-ext release is skipped, the next django-stubs-ext release can skip some numbers to catch up to django-stubs).I want to re-iterate that this does not in any way change our policy for older Django versions. Type stubs have always tracked the latest Django version, but Django itself tends to be fairly backwards compatible. And we will continue running CI tests with older Django versions and make sure we don't break them in a big way.
Action items
DJANGO_COMMIT_REFS
intypecheck_tests.py
. I'm afraid updating the ignore lists will be a significant amount of work. Perhaps it's not a release blocker.django-stubs-ext
TypedModelMeta
.Please let me know if I missed something.
The text was updated successfully, but these errors were encountered: