-
Notifications
You must be signed in to change notification settings - Fork 127
twisted-alike (so similar) automatic publishing on gha #315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
b2c76a1
twisted-alike (so similar) automatic publishing on gha
altendky e7c8d0e
correct needs to pypi-publish
altendky 784985c
add 315.misc.rst
altendky f7cba21
doubly --ignore "admin/**"
altendky 1ffe69b
Update ci.yml
altendky 962dfb0
Update check_tag_version_match.py
altendky 843f0b2
properly handle manifest
altendky 6f48d84
Merge branch 'master' into gha_publish
altendky 949b87c
Merge branch 'master' into gha_publish
altendky 5a269d3
adjust
altendky 516f05a
set -vx
altendky b01e35b
exploratory ls -la
altendky e20699b
check-manifest toxinidir
altendky 5b7f834
MANIFEST.in: include tox_check-release.sh
altendky 748aa96
allow-list
altendky 86ccca4
$
altendky 96a28cf
set the env var
altendky 968cb2b
download the package
altendky 61a45ae
needs build
altendky b014660
check-manifest in tox build needs no extra args
altendky 4aeec25
drop separate manifest and release checks
altendky 4463f03
twine needed for build now
altendky b88edb7
Update ci.yml
altendky c8bb9a8
21.3.0.dev0 for upload testing
altendky eeef046
actually trigger actions on tags
altendky 888b080
21.3.0.dev1 for upload testing
altendky a174db7
install pep517 for tag checking
altendky 82af8ae
21.3.0.dev2 for upload testing
altendky c571289
21.3.0.dev4 for upload testing - wrong tag then right tag
altendky 7c2b3b0
Merge pull request #3 from twisted/gha_publish_test
altendky 149c27f
Merge branch 'gha_publish_test' into gha_publish
altendky e7a136c
Merge branch 'master' into gha_publish
altendky File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| # | ||
| # Used during the release process to make sure that we release based on a | ||
| # tag that has the same version as the current twisted.__version. | ||
| # | ||
| # Designed to be conditionally called inside GitHub Actions release job. | ||
| # Tags should use PEP440 version scheme. | ||
| # | ||
| # To be called as: admin/check_tag_version_match.py refs/tags/twisted-20.3.0 | ||
| # | ||
| import sys | ||
|
|
||
| import pep517.meta | ||
|
|
||
| TAG_PREFIX = "refs/tags/" | ||
|
|
||
| if len(sys.argv) < 2: | ||
| print("No tag check requested.") | ||
| sys.exit(0) | ||
|
|
||
| branch_version = pep517.meta.load(".").version | ||
| run_version = sys.argv[1] | ||
|
|
||
| if not run_version.startswith(TAG_PREFIX): | ||
| print("Not a twisted release tag name '{}.".format(run_version)) | ||
| sys.exit(1) | ||
|
|
||
| run_version = run_version[len(TAG_PREFIX) :] | ||
|
|
||
| if run_version != branch_version: | ||
| print("Branch is at '{}' while tag is '{}'".format(branch_version, run_version)) | ||
| exit(1) | ||
|
|
||
| print("All good. Branch and tag versions match for '{}'.".format(branch_version)) | ||
| sys.exit(0) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,16 @@ | ||
| # build the sdist | ||
|
|
||
| set -evx | ||
|
|
||
| check-manifest --verbose ${toxinidir} | ||
|
|
||
| python -m build --sdist --outdir ${toxinidir}/dist/ ${toxinidir} | ||
|
|
||
| tar -xvf ${toxinidir}/dist/* | ||
| cd * | ||
|
|
||
| # build the wheel from the sdist | ||
| python -m build --wheel --outdir ${toxinidir}/dist/ . | ||
| cd - | ||
|
|
||
| twine check ${toxinidir}/dist/* |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why double ? just asking :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet
So it will match even if the tag ends up having a
/in it. Not something we need, just my default at this point when saying 'anything'.