Skip to content

Conversation

@altendky
Copy link
Member

@altendky altendky commented Jan 17, 2021

Stalled on:

@codecov
Copy link

codecov bot commented Jan 17, 2021

Codecov Report

Merging #315 (e7a136c) into master (499c8f7) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #315   +/-   ##
=======================================
  Coverage   96.78%   96.78%           
=======================================
  Files          20       20           
  Lines        1183     1183           
  Branches      106      106           
=======================================
  Hits         1145     1145           
  Misses         20       20           
  Partials       18       18           
Impacted Files Coverage Δ
src/towncrier/_version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 499c8f7...e7a136c. Read the comment docs.

@adiroiban
Copy link
Member

This looks good.
For validating this PR my suggestion is to first push something like 11.1dev1 tag to check that the publish is blocked due to tag mismatch.

Then update the version to 21.3.dev1 and push that tag to make sure publishing to public repo works.

Then we can merge this and delete the dev1 release from PyPi.

Thanks!

@altendky
Copy link
Member Author

@altendky altendky marked this pull request as ready for review March 19, 2021 01:25
@altendky altendky requested a review from adiroiban March 19, 2021 01:25
Copy link
Member

@adiroiban adiroiban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful work. Thanks! Looking forward to the public release :)

on:
push:
branches: [ master ]
tags: [ "**" ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why double ? just asking :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet

*: Matches zero or more characters, but does not match the / character. For example, Octo* matches Octocat.
**: Matches zero or more of any character.

So it will match even if the tag ends up having a / in it. Not something we need, just my default at this point when saying 'anything'.

from incremental import Version

__version__ = Version("towncrier", 19, 2, 0)
__version__ = Version("towncrier", 21, 3, 0, dev=1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use dev4 as this was the last released ?

Suggested change
__version__ = Version("towncrier", 21, 3, 0, dev=1)
__version__ = Version("towncrier", 21, 3, 0, dev=4)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh... I definitely didn't mean to do this, lemme find where I lost that. Thanks.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, merge and fork and branch and PR and everything more confusion. Sorry, thanks. There was something else missing so this is a good catch.

149c27f

@altendky altendky merged commit 7267fb5 into twisted:master Mar 20, 2021
@altendky altendky deleted the gha_publish branch March 20, 2021 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants