Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pagination with next_page_url #110

Merged
merged 4 commits into from
Aug 9, 2021
Merged

fix: pagination with next_page_url #110

merged 4 commits into from
Aug 9, 2021

Conversation

shwetha-manvinkurke
Copy link
Contributor

Fixes

Fixes #109

  • fix pagination logic
  • add more tests for client logic

@shwetha-manvinkurke shwetha-manvinkurke mentioned this pull request Aug 9, 2021
Closed
zs-codex
zs-codex approved these changes Aug 9, 2021
View reviewed changes
Copy link

@zs-codex zs-codex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

childish-sambino
childish-sambino approved these changes Aug 9, 2021
View reviewed changes
Copy link
Contributor

@childish-sambino childish-sambino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but unit tests need addressing as discussed offline.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 9, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@shwetha-manvinkurke shwetha-manvinkurke merged commit 43c0735 into main Aug 9, 2021
@shwetha-manvinkurke shwetha-manvinkurke deleted the pagination-fix branch August 9, 2021 21:30
@shwetha-manvinkurke shwetha-manvinkurke mentioned this pull request Aug 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zs-codex zs-codex zs-codex approved these changes

@childish-sambino childish-sambino childish-sambino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

StreamServiceConversation always limited to 50 Conversations
3 participants
@shwetha-manvinkurke @childish-sambino @zs-codex