Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StreamServiceConversation always limited to 50 Conversations #109

Closed
zs-codex opened this issue Aug 7, 2021 · 1 comment · Fixed by #110
Closed

StreamServiceConversation always limited to 50 Conversations #109

zs-codex opened this issue Aug 7, 2021 · 1 comment · Fixed by #110
Labels
type: bug bug in the library

Comments

@zs-codex
Copy link

zs-codex commented Aug 7, 2021

Issue Summary

We have more than 50+ Conversations but the StreamServiceConversation returned channel only receives up to the default 50 conversations before closing the channel. The expectation is that the channel returned by StreamServiceConversation will close only after all conversations have been retrieved.

Steps to Reproduce

  1. Create more than 50 service conversations for a service
  2. Attempt to Stream (or List) all of the conversations in the service
  3. Notice that the Stream ends at 50.

Code Snippet

	conversations, err := client.ConversationsV1.StreamServiceConversation(*service.Sid, &conversations.ListServiceConversationParams{})
	if err != nil {
		return err
	}

Technical details:

  • twilio-go version: 0.13.0
  • go version: 1.16
@shwetha-manvinkurke
Copy link
Contributor

@zs-codex Thanks for reporting. Working on a fix here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug bug in the library
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants