Merged
Conversation
1b44d51 to
341be71
Compare
341be71 to
97edc23
Compare
Erk-
requested changes
Dec 22, 2022
Member
Erk-
left a comment
There was a problem hiding this comment.
The changes looks overall good
I am not really a fan of switching it to parse strings around for a couple of reasons
- It is less flexible in general for what you can do with them
- It makes some optimizations have less gain such as simd-json which does with simd accelerated checking of utf-8.
Co-authored-by: Erk <Erk-@users.noreply.github.com>
AEnterprise
approved these changes
Dec 28, 2022
7596ff
approved these changes
Dec 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
Inflaterinternal buffer and instead returns the decompressed (and nowString) message directly. Note that this does not add any allocations since the old implementation took the buffer on each message (which also probably caused bugs when events were split across two compressed messages). The old implementation also faultily always returnedNonewhen decompression was disabled, making it impossible to process messages. There are also other smaller improvements caused by this rewrite.Removes the
Message::Binaryvariant since decompressed must now beStrings to be valid. Users should not have a problem being restricted to UTF-8 messages since the gateway only accepts JSON encoded events.Removes the
metricsfeature and conditionally exposes theInflaterdirectly for users to use however they wish.Fixes #1990