feat: record group fetch more #8868
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| import { RecordGroupDefinition } from '@/object-record/record-group/types/RecordGroupDefinition'; | ||
| import { createComponentFamilyStateV2 } from '@/ui/utilities/state/component-state/utils/createComponentFamilyStateV2'; | ||
| import { ViewComponentInstanceContext } from '@/views/states/contexts/ViewComponentInstanceContext'; | ||
|
|
||
| export const recordIndexHasFetchedAllRecordsByGroupComponentState = | ||
| createComponentFamilyStateV2<boolean, RecordGroupDefinition['id']>({ | ||
| key: 'recordIndexHasFetchedAllRecordsByGroupComponentState', | ||
| componentInstanceContext: ViewComponentInstanceContext, | ||
| defaultValue: false, | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| import { RecordGroupDefinition } from '@/object-record/record-group/types/RecordGroupDefinition'; | ||
| import { createComponentFamilyStateV2 } from '@/ui/utilities/state/component-state/utils/createComponentFamilyStateV2'; | ||
| import { ViewComponentInstanceContext } from '@/views/states/contexts/ViewComponentInstanceContext'; | ||
|
|
||
| export const recordIndexShouldFetchMoreRecordsByGroupComponentState = | ||
| createComponentFamilyStateV2<boolean, RecordGroupDefinition['id']>({ | ||
| key: 'recordIndexShouldFetchMoreRecordsByGroupComponentState', | ||
| componentInstanceContext: ViewComponentInstanceContext, | ||
| defaultValue: false, | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| import styled from '@emotion/styled'; | ||
|
|
||
| import { RecordTableTd } from '@/object-record/record-table/record-table-cell/components/RecordTableTd'; | ||
| import { visibleTableColumnsComponentSelector } from '@/object-record/record-table/states/selectors/visibleTableColumnsComponentSelector'; | ||
| import { useRecoilComponentValueV2 } from '@/ui/utilities/state/component-state/hooks/useRecoilComponentValueV2'; | ||
| import { useTheme } from '@emotion/react'; | ||
| import { IconComponent } from 'twenty-ui'; | ||
|
|
||
| const StyledTrContainer = styled.tr` | ||
| cursor: pointer; | ||
| `; | ||
|
|
||
| const StyledIconContainer = styled(RecordTableTd)` | ||
| border-right: none; | ||
| color: ${({ theme }) => theme.font.color.secondary}; | ||
| text-align: center; | ||
| vertical-align: middle; | ||
| padding-top: 3px; | ||
| `; | ||
|
|
||
| const StyledRecordTableTdTextContainer = styled(RecordTableTd)` | ||
| border-right: none; | ||
| height: 32px; | ||
| `; | ||
|
|
||
| const StyledText = styled.span` | ||
| color: ${({ theme }) => theme.font.color.tertiary}; | ||
| margin-left: ${({ theme }) => theme.spacing(2)}; | ||
| font-size: ${({ theme }) => theme.font.size.md}; | ||
| text-align: center; | ||
| vertical-align: middle; | ||
| `; | ||
|
|
||
| const StyledEmptyTd = styled.td` | ||
| border-bottom: 1px solid ${({ theme }) => theme.border.color.light}; | ||
| `; | ||
|
|
||
| type RecordTableActionRowProps = { | ||
| LeftIcon: IconComponent; | ||
| text: string; | ||
| onClick?: (event?: React.MouseEvent<HTMLTableRowElement>) => void; | ||
| }; | ||
|
Comment on lines
+38
to
+42
There was a problem hiding this comment. logic: onClick handler should be required since this is an interactive component - remove the optional '?' from the type definition |
||
|
|
||
| export const RecordTableActionRow = ({ | ||
| LeftIcon, | ||
| text, | ||
| onClick, | ||
| }: RecordTableActionRowProps) => { | ||
| const theme = useTheme(); | ||
|
|
||
| const visibleColumns = useRecoilComponentValueV2( | ||
| visibleTableColumnsComponentSelector, | ||
| ); | ||
|
|
||
| return ( | ||
| <StyledTrContainer onClick={onClick}> | ||
| <td aria-hidden /> | ||
| <StyledIconContainer> | ||
| <LeftIcon size={theme.icon.size.sm} color={theme.font.color.tertiary} /> | ||
| </StyledIconContainer> | ||
| <StyledRecordTableTdTextContainer colSpan={visibleColumns.length}> | ||
| <StyledText>{text}</StyledText> | ||
| </StyledRecordTableTdTextContainer> | ||
| <StyledEmptyTd /> | ||
| <StyledEmptyTd /> | ||
| </StyledTrContainer> | ||
| ); | ||
| }; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| import { useCurrentRecordGroupId } from '@/object-record/record-group/hooks/useCurrentRecordGroupId'; | ||
| import { recordIndexHasFetchedAllRecordsByGroupComponentState } from '@/object-record/record-index/states/recordIndexHasFetchedAllRecordsByGroupComponentState'; | ||
| import { recordIndexShouldFetchMoreRecordsByGroupComponentState } from '@/object-record/record-index/states/recordIndexShouldFetchMoreRecordsByGroupComponentState'; | ||
| import { RecordTableActionRow } from '@/object-record/record-table/record-table-row/components/RecordTableActionRow'; | ||
| import { useRecoilComponentFamilyValueV2 } from '@/ui/utilities/state/component-state/hooks/useRecoilComponentFamilyValueV2'; | ||
| import { useSetRecoilComponentFamilyStateV2 } from '@/ui/utilities/state/component-state/hooks/useSetRecoilComponentFamilyStateV2'; | ||
| import { IconArrowDown } from 'twenty-ui'; | ||
|
|
||
| export const RecordTableRecordGroupSectionLoadMore = () => { | ||
| const currentRecordGroupId = useCurrentRecordGroupId(); | ||
|
|
||
| const hasFetchedAllRecords = useRecoilComponentFamilyValueV2( | ||
| recordIndexHasFetchedAllRecordsByGroupComponentState, | ||
| currentRecordGroupId, | ||
| ); | ||
|
|
||
| const setShouldFetchMoreRecords = useSetRecoilComponentFamilyStateV2( | ||
| recordIndexShouldFetchMoreRecordsByGroupComponentState, | ||
| currentRecordGroupId, | ||
| ); | ||
|
|
||
| const handleLoadMore = () => { | ||
| setShouldFetchMoreRecords(true); | ||
| }; | ||
|
|
||
| if (hasFetchedAllRecords) { | ||
| return null; | ||
| } | ||
|
|
||
| return ( | ||
| <RecordTableActionRow | ||
| LeftIcon={IconArrowDown} | ||
| text="Load more" | ||
| onClick={handleLoadMore} | ||
| /> | ||
| ); | ||
| }; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Consider making the 8 record limit configurable via a constant rather than hardcoding the value