feat: record group fetch more #8868
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR replaces infinite scroll with a "Load more" button for grouped records in table view, limiting initial fetch to 8 records per group and allowing manual loading of additional records.
- Added
recordIndexShouldFetchMoreRecordsByGroupComponentStateandrecordIndexHasFetchedAllRecordsByGroupComponentStateRecoil family states to manage pagination per group - Modified
useLoadRecordIndexTableto limit initial fetch to 8 records when grouping is active - Added new
RecordTableRecordGroupSectionLoadMorecomponent to render "Load more" button below each group - Added
RecordTableActionRowcomponent for consistent styling of action rows with icons and text - Updated
RecordTableRecordGroupBodyEffectto handle group-specific record loading and state management
9 file(s) reviewed, 5 comment(s)
Edit PR Review Bot Settings | Greptile
| @@ -84,6 +84,8 @@ export const useFindManyParams = ( | |||
| ...recordGroupFilter, | |||
| }, | |||
| orderBy, | |||
| // If we have a current record group definition, we only want to fetch 8 records by page | |||
| ...(currentRecordGroupDefinition ? { limit: 8 } : {}), | |||
There was a problem hiding this comment.
style: Consider making the 8 record limit configurable via a constant rather than hardcoding the value
| fetchMoreRecords().finally(() => { | ||
| setShouldFetchMoreRecords(false); | ||
| }); | ||
| } |
There was a problem hiding this comment.
logic: Missing error handling for failed fetch operations. The state should be reset even if the fetch fails.
| type RecordTableActionRowProps = { | ||
| LeftIcon: IconComponent; | ||
| text: string; | ||
| onClick?: (event?: React.MouseEvent<HTMLTableRowElement>) => void; | ||
| }; |
There was a problem hiding this comment.
logic: onClick handler should be required since this is an interactive component - remove the optional '?' from the type definition
| @@ -108,8 +108,8 @@ export const RecordTableRecordGroupSection = () => { | |||
| /> | |||
| <StyledTotalRow>{recordIdsByGroup.length}</StyledTotalRow> | |||
There was a problem hiding this comment.
style: recordIdsByGroup.length may not reflect total records when paginated. Consider showing total count instead
| <StyledEmptyTd /> | ||
| <StyledEmptyTd /> |
There was a problem hiding this comment.
style: empty td elements should have aria-hidden for better accessibility
Fix #8756
This PR is adding a load more button when we're grouping by a field in table view.
Only 8 records are printed at first, and a click on
Load moreis needed to show more records.