Prefill workspace invitation email (#7174) #8826
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR implements email prefilling for workspace invitations, replacing the generic sign-in prefill state with a more specific developer default state.
- Added email prefilling from invitation links in
useSignInUpForm.tsby reading URL search params - Modified
workspace-invitation.service.tsto include email parameter in invitation links - Replaced
isSignInPrefilledStatewithisDeveloperDefaultSignInPrefilledStatefor development/testing purposes - Simplified
WorkspaceInviteTeamcomponent by removing redundanthandleKeyDownhandler - Updated auth tests to reflect new state management approach
💡 (3/5) Reply to the bot's comments like "Can you suggest a fix for this @greptileai?" or ask follow-up questions!
8 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
| const isDeveloperDefaultSignInPrefilled = useRecoilValue( | ||
| isDeveloperDefaultSignInPrefilledState, | ||
| ); |
There was a problem hiding this comment.
style: consider using object destructuring with useRecoilValue to improve readability and reduce line count
| const setisDeveloperDefaultSignInPrefilled = useSetRecoilState( | ||
| isDeveloperDefaultSignInPrefilledState, |
There was a problem hiding this comment.
style: camelCase naming convention not followed for 'setisDeveloperDefaultSignInPrefilled' - first word should be capitalized
| link.searchParams.set('inviteToken', invitation.value.appToken.value); | ||
| link.searchParams.set('email', invitation.value.email); | ||
| } |
There was a problem hiding this comment.
logic: Consider URL encoding the email parameter value to prevent potential URL injection issues
| @@ -20,7 +20,9 @@ export const ClientConfigProviderEffect = () => { | |||
| const setIsDebugMode = useSetRecoilState(isDebugModeState); | |||
| const setIsAnalyticsEnabled = useSetRecoilState(isAnalyticsEnabledState); | |||
|
|
|||
| const setIsSignInPrefilled = useSetRecoilState(isSignInPrefilledState); | |||
| const setisDeveloperDefaultSignInPrefilled = useSetRecoilState( | |||
There was a problem hiding this comment.
| const setisDeveloperDefaultSignInPrefilled = useSetRecoilState( | |
| const setIsDeveloperDefaultSignInPrefilled = useSetRecoilState( |
packages/twenty-front/src/modules/client-config/components/ClientConfigProviderEffect.tsx
Outdated
Show resolved
Hide resolved
…entConfigProviderEffect.tsx Co-authored-by: Antoine Moreaux <[email protected]>
|
I think the error might have to do with clicking twice on the button? If it's too slow users tend to click twice. Could be a wrong lead. Let's close the PR like this and you can fix the item (3) in another PR @eliasylonen? |
|
Thanks @eliasylonen for your contribution! |
Prefill workspace invitation email, fixes #7174