Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow-ups after new email invite feature #7174

Closed
FelixMalfait opened this issue Sep 20, 2024 · 4 comments · Fixed by #8826
Closed

Follow-ups after new email invite feature #7174

FelixMalfait opened this issue Sep 20, 2024 · 4 comments · Fixed by #8826
Assignees
@eliasylonen
Labels
prio: high scope: back+front Issues requiring full-stack knowledge

Comments

@FelixMalfait
Copy link
Member

FelixMalfait commented Sep 20, 2024 •
edited
Loading

Issue 1 (design): Alignment

Crop the user name

Screenshot 2024-09-20 at 09 34 19

Issue 2 (nice to have): email prefill or don't check email

Screenshot 2024-09-20 at 09 28 38

If you already know my email then you should prefill it in the UI!
But do we really want to force the email to be the same? Security vs UX tradeoff - what is the market practise? (Check Notion, Linear, etc.).
cc @Bonapara any opinion?

Issue 3 (bug): Message when accepting the invite

This is not a blocking error but I was shown this when accepting the invite

Screenshot 2024-09-20 at 09 29 11£
This bug might have been there before already, probably not linked...
@FelixMalfait FelixMalfait added type: bug scope: back+front Issues requiring full-stack knowledge prio: high labels Sep 20, 2024
@Bonapara
Copy link
Member

For 2) I think the email prefill is the best option!

@FelixMalfait
Copy link
Member Author

FelixMalfait commented Nov 12, 2024 •
edited
Loading

@ad-elias will look into this (maybe this can be closed entirely and isn't up to date)

@eliasylonen eliasylonen mentioned this issue Dec 2, 2024
Merged
@eliasylonen
Copy link
Contributor

  1. Is already fixed
  2. PR here Prefill workspace invitation email (#7174) #8826
  3. Could not reproduce, seems already fixed

@AMoreaux
Copy link
Contributor

AMoreaux commented Dec 2, 2024

The third point remain when I tested on this PR: #8826

FelixMalfait added a commit that referenced this issue Dec 2, 2024
@eliasylonen @ad-elias
@FelixMalfait @AMoreaux
Prefill workspace invitation email (#7174) (#8826)
b6701a8 
Prefill workspace invitation email, fixes #7174

---------

Co-authored-by: ad-elias <[email protected]>
Co-authored-by: Félix Malfait <[email protected]>
Co-authored-by: Antoine Moreaux <[email protected]>
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Product development ✅ Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eliasylonen eliasylonen

Labels
prio: high scope: back+front Issues requiring full-stack knowledge
Projects
Product development ✅
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prefill workspace invitation email (#7174) eliasylonen/twenty
4 participants
@eliasylonen @FelixMalfait @AMoreaux @Bonapara