toggle Field on label between singular and plural based on relation type #8817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Implemented dynamic label toggling for relation fields in the data model settings, switching between singular and plural forms based on the selected relation type.
- Added conditional label rendering in
/packages/twenty-front/src/modules/settings/data-model/fields/forms/relation/components/SettingsDataModelFieldRelationForm.tsxusingselectedRelationType - Integrated with
useRelationSettingsFormInitialValueshook to handle initial label state - Connected label toggle logic to
RELATION_TYPESconstants for type-based switching - Leveraged
objectMetadataItempropertieslabelSingularandlabelPluralfor dynamic text display
💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!
2 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
104
to
108
| watchFormValue( | ||
| 'relation.objectMetadataId', | ||
| initialRelationObjectMetadataItem?.id, | ||
|
|
||
| ), |
There was a problem hiding this comment.
style: unnecessary whitespace after and before parentheses
Comment on lines
111
to
118
| const selectedRelationType=RELATION_TYPE_OPTIONS.find((relationType)=>{ | ||
|
|
||
| return watchFormValue( | ||
| 'relation.type', | ||
| initialRelationType, | ||
|
|
||
| )===relationType.value | ||
| }) |
There was a problem hiding this comment.
logic: missing null check - selectedRelationType could be undefined if no match is found
omarNaifer12
deleted the
feature/7683-toggle-singular-plural-relation-label
branch
|
@FelixMalfait Thank you for reviewing and approving my pull request! I appreciate the opportunity to contribute to this project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7683
Hello,
I’ve implemented the logic for dynamically toggling the Field on label between singular and plural based on the relation type selected by the user. Here's an overview of the changes:
Added a variable selectedRelationType to store the user’s selected relation type.
Based on this variable, I determine whether to use labelPlural or labelSingular from the selectedObjectMetadataItem.
Please review my changes and let me know if there's anything that needs improvement .