-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Field on label should change singular to plural based on relation type #7683
Comments
This issue is not part of oss.gg hackathon. Please pick a different one or start with a side quest |
/oss.gg 200 |
Thanks for opening an issue! It's live on oss.gg! |
/assign |
Assigned to @Cyanhead! Please open a draft PR linking this issue within 48h |
/assign |
This issue is already assigned to another person. Please find more issues here. |
/assign |
This issue is already assigned to another person. Please find more issues here. |
@Cyanhead, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically. |
/assign |
This issue is already assigned to another person. Please find more issues here. |
Hi @ehconitin, I'm having some difficulty with where exactly to implement the fix for this issue. I have an idea of the cause, but i'm not sure where/how to pass the data. PHOTO A: It looks like the reason the plural is not being applied is because the PHOTO B: PHOTO C: The |
/assign |
This issue is already assigned to another person. Please find more issues here. |
/assign |
This issue is already assigned to another person. Please find more issues here. |
@ehconitin Hello, is this issue still available? Can I work on it? |
/assign |
This issue is not part of oss.gg hackathon. Please pick a different one or start with a side quest |
@FelixMalfait @ehconitin Hello, Thank you! |
@omarNaifer12 no problem! Thanks 😊 |
…ype (#8817) #7683 ![labelPlural](https://github.com/user-attachments/assets/3e620d7e-dd51-4e4e-a9ba-289f2685ddf3) ![labelSingular](https://github.com/user-attachments/assets/84739ac5-29b4-48c8-8a71-3f8f2816641b) Hello, I’ve implemented the logic for dynamically toggling the Field on label between singular and plural based on the relation type selected by the user. Here's an overview of the changes: Added a variable selectedRelationType to store the user’s selected relation type. Based on this variable, I determine whether to use labelPlural or labelSingular from the selectedObjectMetadataItem. Please review my changes and let me know if there's anything that needs improvement . --------- Co-authored-by: Félix Malfait <[email protected]>
Current behavior
Expected behavior
The text was updated successfully, but these errors were encountered: