Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put workflow run actions behind feature flag #8796

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Put workflow run actions behind feature flag #8796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ion-menu/actions/record-agnostic-actions/components/RecordAgnosticActionsSetterEffect.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { useRecordAgnosticActions } from '@/action-menu/actions/record-agnostic-actions/hooks/useGlobalActions';
import { useRecordAgnosticActions } from '@/action-menu/actions/record-agnostic-actions/hooks/useRecordAgnosticActions';
import { useEffect } from 'react';

export const RecordAgnosticActionsSetterEffect = () => {
Expand Down
0 ...gnostic-actions/hooks/useGlobalActions.ts → ...actions/hooks/useRecordAgnosticActions.ts
View file
Open in desktop
File renamed without changes.
7 changes: 7 additions & 0 deletions ...menu/actions/record-agnostic-actions/workflow-run-actions/hooks/useWorkflowRunActions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,15 @@ import { SnackBarVariant } from '@/ui/feedback/snack-bar-manager/components/Snac
import { useSnackBar } from '@/ui/feedback/snack-bar-manager/hooks/useSnackBar';
import { useAllActiveWorkflowVersions } from '@/workflow/hooks/useAllActiveWorkflowVersions';
import { useRunWorkflowVersion } from '@/workflow/hooks/useRunWorkflowVersion';
import { useIsFeatureEnabled } from '@/workspace/hooks/useIsFeatureEnabled';

import { useTheme } from '@emotion/react';
import { IconSettingsAutomation } from 'twenty-ui';
import { capitalize } from '~/utils/string/capitalize';

export const useWorkflowRunActions = () => {
const isWorkflowEnabled = useIsFeatureEnabled('IS_WORKFLOW_ENABLED');

const { addActionMenuEntry, removeActionMenuEntry } = useActionMenuEntries();

const { records: activeWorkflowVersions } = useAllActiveWorkflowVersions({
Expand All @@ -26,6 +29,10 @@ export const useWorkflowRunActions = () => {
const theme = useTheme();

const addWorkflowRunActions = () => {
if (!isWorkflowEnabled) {
return;
}

for (const [
index,
activeWorkflowVersion,
Expand Down
5 changes: 4 additions & 1 deletion packages/twenty-front/src/modules/action-menu/components/RecordIndexActionMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,15 @@ import { ActionMenuContext } from '@/action-menu/contexts/ActionMenuContext';

import { contextStoreCurrentObjectMetadataIdComponentState } from '@/context-store/states/contextStoreCurrentObjectMetadataIdComponentState';
import { useRecoilComponentValueV2 } from '@/ui/utilities/state/component-state/hooks/useRecoilComponentValueV2';
import { useIsFeatureEnabled } from '@/workspace/hooks/useIsFeatureEnabled';

export const RecordIndexActionMenu = () => {
const contextStoreCurrentObjectMetadataId = useRecoilComponentValueV2(
contextStoreCurrentObjectMetadataIdComponentState,
);

const isWorkflowEnabled = useIsFeatureEnabled('IS_WORKFLOW_ENABLED');

return (
<>
{contextStoreCurrentObjectMetadataId && (
Expand All @@ -28,7 +31,7 @@ export const RecordIndexActionMenu = () => {
<ActionMenuConfirmationModals />
<RecordIndexActionMenuEffect />
<RecordActionMenuEntriesSetter />
<RecordAgnosticActionsSetterEffect />
{isWorkflowEnabled && <RecordAgnosticActionsSetterEffect />}
</ActionMenuContext.Provider>
)}
</>
Expand Down
5 changes: 4 additions & 1 deletion packages/twenty-front/src/modules/action-menu/components/RecordShowActionMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import { contextStoreCurrentObjectMetadataIdComponentState } from '@/context-sto
import { ObjectMetadataItem } from '@/object-metadata/types/ObjectMetadataItem';
import { ObjectRecord } from '@/object-record/types/ObjectRecord';
import { useRecoilComponentValueV2 } from '@/ui/utilities/state/component-state/hooks/useRecoilComponentValueV2';
import { useIsFeatureEnabled } from '@/workspace/hooks/useIsFeatureEnabled';
import { RecordShowPageBaseHeader } from '~/pages/object-record/RecordShowPageBaseHeader';

export const RecordShowActionMenu = ({
Expand All @@ -26,6 +27,8 @@ export const RecordShowActionMenu = ({
contextStoreCurrentObjectMetadataIdComponentState,
);

const isWorkflowEnabled = useIsFeatureEnabled('IS_WORKFLOW_ENABLED');

// TODO: refactor RecordShowPageBaseHeader to use the context store

return (
Expand All @@ -48,7 +51,7 @@ export const RecordShowActionMenu = ({
/>
<ActionMenuConfirmationModals />
<RecordActionMenuEntriesSetter />
<RecordAgnosticActionsSetterEffect />
{isWorkflowEnabled && <RecordAgnosticActionsSetterEffect />}
</ActionMenuContext.Provider>
)}
</>
Expand Down
5 changes: 4 additions & 1 deletion packages/twenty-front/src/modules/action-menu/components/RecordShowRightDrawerActionMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,15 @@ import { ActionMenuContext } from '@/action-menu/contexts/ActionMenuContext';

import { contextStoreCurrentObjectMetadataIdComponentState } from '@/context-store/states/contextStoreCurrentObjectMetadataIdComponentState';
import { useRecoilComponentValueV2 } from '@/ui/utilities/state/component-state/hooks/useRecoilComponentValueV2';
import { useIsFeatureEnabled } from '@/workspace/hooks/useIsFeatureEnabled';

export const RecordShowRightDrawerActionMenu = () => {
const contextStoreCurrentObjectMetadataId = useRecoilComponentValueV2(
contextStoreCurrentObjectMetadataIdComponentState,
);

const isWorkflowEnabled = useIsFeatureEnabled('IS_WORKFLOW_ENABLED');

return (
<>
{contextStoreCurrentObjectMetadataId && (
Expand All @@ -24,7 +27,7 @@ export const RecordShowRightDrawerActionMenu = () => {
<RightDrawerActionMenuDropdown />
<ActionMenuConfirmationModals />
<RecordActionMenuEntriesSetter />
<RecordAgnosticActionsSetterEffect />
{isWorkflowEnabled && <RecordAgnosticActionsSetterEffect />}
</ActionMenuContext.Provider>
)}
</>
Expand Down
Loading