Put workflow run actions behind feature flag #8796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR implements feature flag controls for workflow run actions across the application, ensuring workflow-related components are only rendered when explicitly enabled.
- Added
IS_WORKFLOW_ENABLEDfeature flag check inuseWorkflowRunActions.tsxto prevent workflow actions from being added to the menu when disabled - Renamed
useGlobalActionstouseRecordAgnosticActionsin/actions/record-agnostic-actions/hooks/useRecordAgnosticActions.tsfor better semantic clarity - Added conditional rendering of
RecordAgnosticActionsSetterEffectin action menu components (RecordIndexActionMenu,RecordShowActionMenu,RecordShowRightDrawerActionMenu) - Implemented proper cleanup pattern in
RecordAgnosticActionsSetterEffectusinguseEffectfor action registration/unregistration
6 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
charlesBochet
approved these changes
Nov 28, 2024
charlesBochet
deleted the
put-workflow-run-actions-behind-feature-flag
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put workflow run actions behind feature flag