Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide the "Expand to Full Page" button on Email and Calendar pages #8615

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

yeonicy
Copy link
Contributor

@yeonicy yeonicy commented Nov 20, 2024

Overview

This pull request addresses issue #8612 by ensuring the "Expand to Full Page" button does not appear on the Email and Calendar pages in the right drawer.

Changes Made

  • Added conditions in the RightDrawerTopBar component to prevent the RightDrawerTopBarExpandButton from rendering on:
    • Email pages (RightDrawerPages.ViewEmailThread)
    • Calendar pages (RightDrawerPages.ViewCalendarEvent)
  • Verified that the button still renders correctly on other pages, such as Record pages.

Testing

Since I couldn't run the project locally, I was unable to confirm the changes in a running environment. However, the logic has been carefully updated to ensure the button is conditionally hidden based on the current rightDrawerPage state.

Additional Notes

Please let me know if further adjustments are needed or if there are any issues during testing. Thank you for reviewing this PR!

@Weiko Weiko self-assigned this Nov 20, 2024
Copy link
Member

@Weiko Weiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

@Weiko Weiko merged commit 8772f8a into twentyhq:main Nov 20, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants