Hide the "Expand to Full Page" button on Email and Calendar pages (#8615

) ### Overview This pull request addresses issue #8612 by ensuring the "Expand to Full Page" button does not appear on the Email and Calendar pages in the right drawer. ### Changes Made - Added conditions in the `RightDrawerTopBar` component to prevent the `RightDrawerTopBarExpandButton` from rendering on: - Email pages (`RightDrawerPages.ViewEmailThread`) - Calendar pages (`RightDrawerPages.ViewCalendarEvent`) - Verified that the button still renders correctly on other pages, such as Record pages. ### Testing Since I couldn't run the project locally, I was unable to confirm the changes in a running environment. However, the logic has been carefully updated to ensure the button is conditionally hidden based on the current `rightDrawerPage` state. ### Additional Notes Please let me know if further adjustments are needed or if there are any issues during testing. Thank you for reviewing this PR! --------- Co-authored-by: Weiko <[email protected]>
twentyhq · Nov 20, 2024 · 8772f8a · 8772f8a
1 parent 39076df
commit 8772f8a
Showing 1 changed file with 19 additions and 15 deletions.
diff --git a/packages/twenty-front/src/modules/ui/layout/right-drawer/components/RightDrawerTopBar.tsx b/packages/twenty-front/src/modules/ui/layout/right-drawer/components/RightDrawerTopBar.tsx
@@ -85,13 +85,14 @@ export const RightDrawerTopBar = () => {
 
   const ObjectIcon = getIcon(objectMetadataItem.icon);
 
-  const label =
-    rightDrawerPage === RightDrawerPages.ViewRecord
-      ? objectMetadataItem.labelSingular
-      : RIGHT_DRAWER_PAGE_TITLES[rightDrawerPage];
+  const isViewRecordRightDrawerPage =
+    rightDrawerPage === RightDrawerPages.ViewRecord;
 
-  const Icon =
-    rightDrawerPage === RightDrawerPages.ViewRecord ? ObjectIcon : PageIcon;
+  const label = isViewRecordRightDrawerPage
+    ? objectMetadataItem.labelSingular
+    : RIGHT_DRAWER_PAGE_TITLES[rightDrawerPage];
+
+  const Icon = isViewRecordRightDrawerPage ? ObjectIcon : PageIcon;
 
   return (
     <StyledRightDrawerTopBar
@@ -122,15 +123,18 @@ export const RightDrawerTopBar = () => {
           <RightDrawerTopBarMinimizeButton />
         )}
 
-        {!isMobile && !isRightDrawerMinimized && (
-          <RightDrawerTopBarExpandButton
-            to={
-              getBasePathToShowPage({
-                objectNameSingular: viewableRecordNameSingular ?? '',
-              }) + viewableRecordId
-            }
-          />
-        )}
+        {!isMobile &&
+          !isRightDrawerMinimized &&
+          isViewRecordRightDrawerPage && (
+            <RightDrawerTopBarExpandButton
+              to={
+                getBasePathToShowPage({
+                  objectNameSingular: viewableRecordNameSingular ?? '',
+                }) + viewableRecordId
+              }
+            />
+          )}
+
         <RightDrawerTopBarCloseButton />
       </StyledTopBarWrapper>
     </StyledRightDrawerTopBar>