Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for horizontal bar while login in #8073

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

sans-byte
Copy link
Contributor

Fix for #8071

@@ -187,7 +187,7 @@ export const SignInUpForm = () => {
</>
)}

<HorizontalSeparator visible={true} />
<HorizontalSeparator visible={authProviders.sso} />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be also visible when we display the Google or Microsoft button

@martmull
Copy link
Contributor

image
image
Fixed condition, remove separator when not needed

Copy link
Contributor

@martmull martmull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

@martmull martmull enabled auto-merge (squash) October 28, 2024 16:55
@martmull martmull merged commit 69c2496 into twentyhq:main Oct 28, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants