Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Horizontal bar in login popup despite no SSO key set #8071

Closed
BOHEUS opened this issue Oct 25, 2024 · 13 comments
Closed

Horizontal bar in login popup despite no SSO key set #8071

BOHEUS opened this issue Oct 25, 2024 · 13 comments
Labels
good first issue Good for newcomers scope: front Issues that are affecting the frontend side only size: short type: design improvement

Comments

@BOHEUS
Copy link
Contributor

BOHEUS commented Oct 25, 2024

Scenario:

  1. Open Twenty

Actual: When login popup appears, user can see unnecessary horizontal bar dividing space between missing "Continue with Google" button and visible "Continue with email" button
image

Expected: Horizontal bar should be visible only if SSO key is added
@Bonapara
Copy link
Member

Thanks, @BOHEUS, it bugs me every time I connect to the local version :)

@Bonapara
Copy link
Member

/oss.gg 150

@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 25, 2024

Thanks for opening an issue! It's live on oss.gg!

@Bonapara Bonapara added good first issue Good for newcomers scope: front Issues that are affecting the frontend side only size: short type: design improvement and removed 🕹️ oss.gg labels Oct 25, 2024
@DeepaPrasanna
Copy link

May I work on this?

@jayabha-jayas
Copy link
Contributor

/assign

@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 25, 2024

This issue is not part of oss.gg hackathon. Please pick a different one or start with a side quest

@sans-byte sans-byte mentioned this issue Oct 25, 2024
Merged
@sans-byte
Copy link
Contributor

Hi, already worked on this while working on other issue as it was looking strange to me too so raised a PR, maybe look at the PR if it's fine. @Bonapara

@karthik-nair-20
Copy link

/assign

@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 26, 2024

This issue is not part of oss.gg hackathon. Please pick a different one or start with a side quest

@karthik-nair-20
Copy link

Screenshot 2024-10-27 at 12 51 45 AM

@dilshad-knk
Copy link
Contributor

are u working on this @karthik-nair-20

@karthik-nair-20
Copy link

Hey @dilshad-knk ,No I did not raise PR, the SS I shared should fix the issue

martmull added a commit that referenced this issue Oct 28, 2024
@sans-byte @martmull
fix for horizontal bar while login in (#8073)
69c2496 
Fix for #8071

---------

Co-authored-by: martmull <[email protected]>
@BOHEUS
Copy link
Contributor Author

BOHEUS commented Oct 29, 2024

I'm closing this issue as fix is merged

@BOHEUS BOHEUS closed this as completed Oct 29, 2024
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Product development ✅ Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers scope: front Issues that are affecting the frontend side only size: short type: design improvement
Projects
Product development ✅
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
7 participants
@Bonapara @jayabha-jayas @sans-byte @DeepaPrasanna @BOHEUS @dilshad-knk @karthik-nair-20