Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken filter in search resolver #8064

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Fix broken filter in search resolver #8064

merged 2 commits into from
Oct 25, 2024

Conversation

ijreilly
Copy link
Collaborator

The recent addition of a "orWhere" condition to improve the search algo quality accidentally broke the filter, being considered an independent "or" wondition while we still want the filter to apply.

Copy link
Member

@Weiko Weiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Weiko Weiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI you can do nested where condition like this

.andWhere(new Brackets(qb => {
        qb.where()
          .orWhere()
    })

@Weiko Weiko merged commit 9303e39 into main Oct 25, 2024
18 checks passed
@Weiko Weiko deleted the fix-relation-picker branch October 25, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants