Improve search algorithm #7955
Merged
Improve search algorithm #7955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijreilly
commented
Oct 22, 2024
| .orderBy( | ||
| `ts_rank("${SEARCH_VECTOR_FIELD.name}", to_tsquery(:searchTerms))`, | ||
| `ts_rank_cd("${SEARCH_VECTOR_FIELD.name}", to_tsquery(:searchTerms))`, |
There was a problem hiding this comment.
ts_rank_cd gives weight to terms proximity which makes sense here as we potentially have more than one term.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request improves the search algorithm by implementing a combined 'AND' and 'OR' search approach, addressing issues with search result relevance and ranking.
- Modified
graphql-query-search-resolver.service.tsto introduce separate 'AND' and 'OR' search term formatting - Updated query builder to use both 'AND' and 'OR' conditions in the WHERE clause
- Implemented new ranking method using
ts_rank_cdfor 'AND' terms andts_rankfor 'OR' terms - Removed dependency on FeatureFlagService, simplifying the implementation
- Enhanced
formatSearchTermsmethod to support both 'AND' and 'OR' operators, improving search flexibility
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
charlesBochet
approved these changes
Oct 22, 2024
Weiko
pushed a commit
that referenced
this pull request
Oct 25, 2024
The recent addition of a "orWhere" condition to[ improve the search algo quality](#7955) accidentally broke the filter, being considered an independent "or" wondition while we still want the filter to apply.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were previously checking for matching with each search term independently. Ex searching for "felix malfait" we were searching for correspondances with "felix" and "malfait".
As a result record A with name "Marie-Claude Mala" and email "[email protected]" had a biggest search score than record B "Felix Malfait" with email [email protected] for search "felix ma":
for record A we had 0 match with felix and 3 matches with "ma" ("marie", "mala", "ma")
for record B we had 1 match with felix and 1 match with "ma" (with "malfait").
So we want to give more weight to a row that would combine matches with both terms, considering "felix malfait" altogether.