-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7415 serverless functions update environment variables in a dedicated tab in settings functions not a env file #7939
Conversation
martmull
commented
Oct 22, 2024
•
edited
Loading
edited
…-variables-in-a-dedicated-tab-in-settings-functions-not-a-env-file
…-variables-in-a-dedicated-tab-in-settings-functions-not-a-env-file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This pull request introduces significant updates to the serverless functions management system, particularly focusing on environment variables handling and version management. Here are the key changes:
- Added a new 'publishedVersions' field to track multiple versions of serverless functions
- Implemented a dedicated tab for managing environment variables in the serverless function settings UI
- Updated GraphQL queries and mutations to support new serverless function management features
- Modified the backend to handle the new 'publishedVersions' column and updated environment variables storage
- Refactored the serverless function service to use TypeORM repository methods directly
24 file(s) reviewed, 15 comment(s)
Edit PR Review Bot Settings | Greptile
...rc/modules/settings/serverless-functions/components/SettingsServerlessFunctionCodeEditor.tsx
Show resolved
Hide resolved
...rless-functions/components/tabs/SettingsServerlessFunctionTabEnvironmentVariableTableRow.tsx
Show resolved
Hide resolved
...rless-functions/components/tabs/SettingsServerlessFunctionTabEnvironmentVariableTableRow.tsx
Show resolved
Hide resolved
...rless-functions/components/tabs/SettingsServerlessFunctionTabEnvironmentVariableTableRow.tsx
Show resolved
Hide resolved
...rless-functions/components/tabs/SettingsServerlessFunctionTabEnvironmentVariablesSection.tsx
Outdated
Show resolved
Hide resolved
...ont/src/modules/settings/serverless-functions/graphql/queries/findManyServerlessFunctions.ts
Show resolved
Hide resolved
...wenty-front/src/modules/settings/serverless-functions/hooks/useGetManyServerlessFunctions.ts
Show resolved
Hide resolved
...wenty-server/src/engine/metadata-modules/serverless-function/dtos/serverless-function.dto.ts
Show resolved
Hide resolved
.../twenty-server/src/engine/metadata-modules/serverless-function/serverless-function.module.ts
Show resolved
Hide resolved
...twenty-server/src/engine/metadata-modules/serverless-function/serverless-function.service.ts
Outdated
Show resolved
Hide resolved
...rless-functions/components/tabs/SettingsServerlessFunctionTabEnvironmentVariableTableRow.tsx
Outdated
Show resolved
Hide resolved
...rless-functions/components/tabs/SettingsServerlessFunctionTabEnvironmentVariablesSection.tsx
Outdated
Show resolved
Hide resolved
...wenty-server/src/engine/metadata-modules/serverless-function/dtos/serverless-function.dto.ts
Show resolved
Hide resolved
...twenty-server/src/engine/metadata-modules/serverless-function/serverless-function.service.ts
Outdated
Show resolved
Hide resolved
...twenty-server/src/engine/metadata-modules/serverless-function/serverless-function.service.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @martmull! I love the new UX.
I have a few questions to understand the future of this feature:
- As far as I understand, the environment variables are still stored in a
.env
file; will we keep it in the future? I remember that we talked about moving it to the database, that's maybe something we'll do in a second step? - Regarding storing environment variables, in the database, do we already have a plan for encryption?