Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7415 serverless functions update environment variables in a dedicated tab in settings functions not a env file #7939

Conversation

martmull
Copy link
Contributor

@martmull martmull commented Oct 22, 2024

image
image
image
image

…-variables-in-a-dedicated-tab-in-settings-functions-not-a-env-file
@martmull martmull marked this pull request as ready for review October 22, 2024 08:02
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request introduces significant updates to the serverless functions management system, particularly focusing on environment variables handling and version management. Here are the key changes:

  • Added a new 'publishedVersions' field to track multiple versions of serverless functions
  • Implemented a dedicated tab for managing environment variables in the serverless function settings UI
  • Updated GraphQL queries and mutations to support new serverless function management features
  • Modified the backend to handle the new 'publishedVersions' column and updated environment variables storage
  • Refactored the serverless function service to use TypeORM repository methods directly

24 file(s) reviewed, 15 comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Contributor

@Devessier Devessier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @martmull! I love the new UX.

I have a few questions to understand the future of this feature:

  • As far as I understand, the environment variables are still stored in a .env file; will we keep it in the future? I remember that we talked about moving it to the database, that's maybe something we'll do in a second step?
  • Regarding storing environment variables, in the database, do we already have a plan for encryption?

@martmull martmull merged commit e767f16 into main Oct 22, 2024
18 checks passed
@martmull martmull deleted the 7415-serverless-functions-update-environment-variables-in-a-dedicated-tab-in-settings-functions-not-a-env-file branch October 22, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants