Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serverless Functions]: Update environment variables in a dedicated tab in settings > Functions, not a .env file #7415

Closed
martmull opened this issue Oct 3, 2024 · 2 comments · Fixed by #7939
Assignees

Comments

@martmull
Copy link
Contributor

martmull commented Oct 3, 2024

Why?
Updating a .env file is not a very common way to add and update environment variables

What?
We want to create a dedicated table in the serverless function detail view to CRUD env variables, and remove the .env file
We can add a new tab, or add a new section in the setting tab
Image
Image
@Bonapara what do you think?

Technically, we could also store environment variables in a dedicated encrypted JSONb column in the metadata.serverlessFunction table and use that to store environment variables instead of a file

@martmull martmull self-assigned this Oct 3, 2024
@martmull martmull converted this from a draft issue Oct 3, 2024
@Bonapara
Copy link
Member

Bonapara commented Oct 3, 2024

@charlesBochet charlesBochet moved this from 🔖 Planned to 🏗 In progress in Product development ✅ Oct 11, 2024
@martmull martmull moved this from 🏗 In progress to 🔖 Planned in Product development ✅ Oct 14, 2024
@martmull
Copy link
Contributor Author

To do also

  • move serverlessFunction from metadata to workspace_schema
  • add a serverlessFunctionVersion table

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
2 participants