fix: use <button> tag for buttons #7797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request modifies the StyledHeaderDropdownButton component to use a <button> tag instead of a <div>, improving accessibility and aligning with semantic HTML best practices.
- Changed
styled.divtostyled.buttoninpackages/twenty-front/src/modules/ui/layout/dropdown/components/StyledHeaderDropdownButton.tsx - Added
font-family: inheritto maintain consistent text styling - Set
border: noneto preserve the original button appearance - Maintained existing functionality and styling while enhancing accessibility
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
packages/twenty-front/src/modules/ui/layout/dropdown/components/StyledHeaderDropdownButton.tsx
Outdated
Show resolved
Hide resolved
Welcome!
Hello there, congrats on your first PR! We're excited to have you contributing to this project. |
|
/assign |
|
This issue is not part of oss.gg hackathon. Please pick a different one or start with a side quest |
Devessier
approved these changes
Oct 21, 2024
Devessier
force-pushed
the
fix/use-button-tag-for-buttons
branch
from
47a74f6
to
48f2b2c
Compare
|
Awarding Pk9697: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/Pk9697 |
|
Thank you it was my first PR ! |
|
Good job, @Pk9697! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR updates div with button tag for buttons
Fixes #7577