Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the <button> tag for buttons #7577

Closed
Tracked by #7803
Bonapara opened this issue Oct 10, 2024 · 68 comments · Fixed by #7797
Closed
Tracked by #7803

Use the <button> tag for buttons #7577

Bonapara opened this issue Oct 10, 2024 · 68 comments · Fixed by #7797
Assignees
@Pk9697
Labels
for experienced contributor prio: low scope: front Issues that are affecting the frontend side only size: long

Comments

@Bonapara
Copy link
Member

Bonapara commented Oct 10, 2024 •
edited
Loading

Current behavior

Buttons are made of div

CleanShot 2024-10-10 at 18 26 00

Desired Behavior

Use HTML tags for accessibility

BEWARE OF REGRESSIONS 🚨

Check that all button states are working fine; otherwise let's use role=button but that's plan b
@Bonapara Bonapara added scope: front Issues that are affecting the frontend side only size: long for experienced contributor prio: low labels Oct 10, 2024
@Bonapara
Copy link
Member Author

/oss.gg 150

@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 10, 2024

Thanks for opening an issue! It's live on oss.gg!

@tsahil01
Copy link

/assign

@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 10, 2024

Assigned to @tsahil01! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

@Mdmehedihasanrifat
Copy link

/assign

@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 10, 2024

This issue is already assigned to another person. Please find more issues here.

1 similar comment
@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 10, 2024

This issue is already assigned to another person. Please find more issues here.

@thisissushant
Copy link

/assign

@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 10, 2024

This issue is already assigned to another person. Please find more issues here.

@lieftsatyamShrivastava
Copy link

assign

@pankaj-kumar-yadav
Copy link

/assign

@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 11, 2024

This issue is already assigned to another person. Please find more issues here.

@sahiladit
Copy link

/assign

@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 11, 2024

This issue is already assigned to another person. Please find more issues here.

@shailjayadav30
Copy link

/assign

@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 11, 2024

This issue is already assigned to another person. Please find more issues here.

@mrjayantbokade
Copy link

/assign

@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 11, 2024

This issue is already assigned to another person. Please find more issues here.

1 similar comment
@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 11, 2024

This issue is already assigned to another person. Please find more issues here.

@Anky9972
Copy link

/assign

@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 11, 2024

This issue is already assigned to another person. Please find more issues here.

@Usmanxs
Copy link

Usmanxs commented Oct 11, 2024

/assign

@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 11, 2024

This issue is already assigned to another person. Please find more issues here.

@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 12, 2024

This issue is already assigned to another person. Please find more issues here.

@AmanPathan
Copy link
Contributor

/assign

@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 12, 2024

This issue is already assigned to another person. Please find more issues here.

@vamsi4845
Copy link

/assign

@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 12, 2024

This issue is already assigned to another person. Please find more issues here.

@AdityaJadhav9423
Copy link

/assign

@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 12, 2024

This issue is already assigned to another person. Please find more issues here.

@satyagithub23
Copy link

/assign

@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 13, 2024

This issue is already assigned to another person. Please find more issues here.

1 similar comment
@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 13, 2024

This issue is already assigned to another person. Please find more issues here.

@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 14, 2024

@tsahil01, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 14, 2024

This issue is already assigned to another person. Please find more issues here.

@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 14, 2024

You cannot unassign this issue as it is not assigned to you.

@PAVANNAIK25
Copy link

/assign

@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 14, 2024

This issue is already assigned to another person. Please find more issues here.

@Sudheer104
Copy link

/assign

@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 15, 2024

This issue is already assigned to another person. Please find more issues here.

@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 16, 2024

@tsahil01, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

@Bonapara
Copy link
Member Author

Hi @tsahil01, I am unassigning you as it has been 6 days.Thank you for contributing!

@Pk9697
Copy link
Contributor

Pk9697 commented Oct 16, 2024

/assign

@oss-gg oss-gg bot assigned Pk9697 Oct 16, 2024
@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 16, 2024

Assigned to @Pk9697! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 16, 2024

This issue is already assigned to another person. Please find more issues here.

@Akshay08k
Copy link

/assign

@oss-gg oss.gg
Copy link

oss-gg bot commented Oct 17, 2024

This issue is already assigned to another person. Please find more issues here.

@Pk9697 Pk9697 mentioned this issue Oct 17, 2024
Merged
@BOHEUS BOHEUS mentioned this issue Oct 17, 2024
Open
Devessier pushed a commit that referenced this issue Oct 21, 2024
@Pk9697
fix: use <button> tag for buttons (#7797)
28c99cb 
## What does this PR do?
This PR updates div with button tag for buttons

Fixes #7577 

![Screenshot 2024-10-17
210955](https://github.com/user-attachments/assets/54a0c0e9-93ed-4730-a738-bf486f1f58c8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pk9697 Pk9697

Labels
for experienced contributor prio: low scope: front Issues that are affecting the frontend side only size: long
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use <button> tag for buttons Pk9697/twenty