-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Custom fields lacks empty tag #7777
fix: Custom fields lacks empty tag #7777
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This pull request addresses the issue of custom fields lacking empty tags, which affected the clickable area for editing and created excessive whitespace.
- Modified
isFieldValueEmpty.ts
to handle empty arrays for relation fields - Updated logic for multi-select and array fields to check for non-empty arrays
- Added new test cases in
isFieldValueEmpty.test.ts
for relation fields with empty and non-empty arrays - Improved handling of empty states for custom fields, enhancing the user interface and editing experience
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
8a30f52
to
a441afa
Compare
Hi @FelixMalfait @Bonapara @lucasbordeau I finished updating the branch. If there is anything I need to change regarding the issue, please lmk. Thank you! |
Thank you! |
/award 300 |
Awarding nganphan123: 300 points 🕹️ Well done! Check out your new contribution on oss.gg/nganphan123 |
Log
|
This PR fixes this issue #7250