-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom fields lacks empty tag #7250
Comments
There was a mistake from my side on providing enough context @Bonapara. As you can see in the screen recording below, custom fields create empty spaces under company. Screen.Recording.2024-09-25.at.6.31.32.PM.mov |
Could reproduce for relation custom fields in dropdowns, thanks @harshit078! |
/oss.gg 200 |
Thanks for opening an issue! It's live on oss.gg! |
Hi, is this available to be taken? Can I work on this? |
Hi @Bonapara , I did some inspection and it seems like the Empty tag is missing for Multi-select and One-to-many data type. The problem lies in the check Lines 89 to 94 in 1b99a05
From what I understand, the Please let me know if I'm on the right track or if there's anything I've misunderstood. Thank you! |
@lucasbordeau WDYT? |
@nganphan123 yes it seems you're on the right track! Thank you! |
@nganphan123 fyi we never really shiped relationToOne in the product in the end. I'd probably do something like this instead (not tested):
Close to what you're saying but better handling of RelationToOne imo (even though we don't use it) |
@FelixMalfait I see. I added the change and it passed the tests. Also,
|
This PR fixes this issue #7250 --------- Co-authored-by: Félix Malfait <[email protected]>
@FelixMalfait this issue can be closed since changes are merged |
Thanks @BOHEUS |
Bug Description
Current behavior
Expected
There should be empty tags in front of custom fields when empty
The text was updated successfully, but these errors were encountered: