Fix: Remove Deleted filter not reflecting issue #7676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR addresses an issue with the 'Remove Deleted filter' functionality in the RecordTableEmptyStateSoftDelete component, ensuring the correct filter is identified and removed when the button is clicked.
- Updated filter label from 'Deleted at' to 'Deleted' in
packages/twenty-front/src/modules/object-record/record-table/empty-state/components/RecordTableEmptyStateSoftDelete.tsx - Fixed the issue where clicking 'Remove Deleted filter' didn't remove the filter as expected
- Ensures consistency between the filter added from options and the one removed by the button
- Resolves the problem reported in issue Remove Deleted filter not reflecting #7626, improving user experience when managing deleted records
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
...odules/object-record/record-table/empty-state/components/RecordTableEmptyStateSoftDelete.tsx
Show resolved
Hide resolved
bosiraphael
approved these changes
Oct 16, 2024
|
Thank you for merging :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This Pull request fixes #7626
Adding Deleted filter from option will add filter label as "Deleted" in tableFiltersState, But on click of "Remove Deleted filter" "Deleted at" is used for finding tableFilter id, which results in tableFilter id as undefined.