Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Deleted filter not reflecting #7626

Closed
J3E1 opened this issue Oct 12, 2024 · 7 comments · Fixed by #7676
Closed

Remove Deleted filter not reflecting #7626

J3E1 opened this issue Oct 12, 2024 · 7 comments · Fixed by #7676
Assignees
Labels
prio: med scope: front Issues that are affecting the frontend side only size: short

Comments

@J3E1
Copy link
Contributor

J3E1 commented Oct 12, 2024

Current behavior

On Deleted filter if none results are found then Remove deleted filter button appears but on clicking it filter doesn't go away unless we remove it from filters.

2024-10-13.01-24-56.mov

Expected behavior

Clicking on the Remove Deleted filter should remove deleted filter and should show items according to that

@J3E1 J3E1 added the type: bug label Oct 12, 2024
@J3E1
Copy link
Contributor Author

J3E1 commented Oct 12, 2024

@Bonapara, I would like to work on this !

@heygogu
Copy link

heygogu commented Oct 13, 2024

interesting

@shivang-tripati
Copy link

/assign

Copy link

oss-gg bot commented Oct 13, 2024

This issue is not part of oss.gg hackathon. Please pick a different one or start with a side quest

@prajyot004
Copy link

@J3E1 It's working fine as expected. Make sure you have synced your forked repository.

@J3E1
Copy link
Contributor Author

J3E1 commented Oct 13, 2024

@prajyot004 can you share working video as I'm checking with latest fork, issue is there. Select Deleted people from options. If no deleted people, Remove deleted people filter button appears but on clicking it Deleted filter doesn't get removed.
Lemme know if something wrong in my testing.

@Bonapara
Copy link
Member

Can reproduce. Assigning you, thanks @J3E1!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio: med scope: front Issues that are affecting the frontend side only size: short
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants