-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker cleanup #7655
Docker cleanup #7655
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, I have left comments
packages/twenty-website/src/content/developers/self-hosting/docker-compose.mdx
Outdated
Show resolved
Hide resolved
/oss.gg 300 |
Thanks for opening an issue! It's live on oss.gg! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This pull request removes Docker development commands from the Makefile and updates related documentation to align with the decision to discontinue support for Docker development containers.
- Removed all development-related Docker commands from
packages/twenty-docker/Makefile
, keeping only production and release commands - Deleted
packages/twenty-docker/twenty-website/Dockerfile
used for development purposes - Updated
packages/twenty-website/src/content/developers/local-setup.mdx
with non-Docker methods for database and Redis setup - Added a warning in
packages/twenty-website/src/content/developers/self-hosting/docker-compose.mdx
clarifying Docker containers are for production or self-hosting only
4 file(s) reviewed, 6 comment(s)
Edit PR Review Bot Settings | Greptile
packages/twenty-website/src/content/developers/self-hosting/docker-compose.mdx
Outdated
Show resolved
Hide resolved
packages/twenty-website/src/content/developers/self-hosting/docker-compose.mdx
Outdated
Show resolved
Hide resolved
packages/twenty-website/src/content/developers/self-hosting/docker-compose.mdx
Outdated
Show resolved
Hide resolved
On it |
Awarding BOHEUS: 300 points 🕹️ Well done! Check out your new contribution on oss.gg/BOHEUS |
Log
|
Related to #7648
@charlesBochet I've deleted only dev related commands in Makefile, if it's wrong, I'll change it ASAP